feat(safe-outputs): allow model-selected PR reviewers - #2099
Draft
jamesadevine with Copilot wants to merge 5 commits into
Draft
feat(safe-outputs): allow model-selected PR reviewers#2099jamesadevine with Copilot wants to merge 5 commits into
jamesadevine with Copilot wants to merge 5 commits into
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
2 tasks
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow model-selected reviewers in create-pull-request
feat(safe-outputs): allow model-selected PR reviewers
Sep 3, 2026
Use generated temporary PR references so update-pr can safely apply model-selected reviewers and other follow-up operations after PR creation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 93d15887-5c0e-4975-98a2-82ca84d35d5f
Exercise ordered create-pull-request and update-pr NDJSON execution through the shared temporary PR registry and mocked Azure DevOps APIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 93d15887-5c0e-4975-98a2-82ca84d35d5f
Update existing create-pull-request fixtures for the required temporary ID and add a deterministic create-then-update handoff scenario in one executor process. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 93d15887-5c0e-4975-98a2-82ca84d35d5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model-selected reviewers need the PR created by the same run, but Azure DevOps assigns its numeric ID only during SafeOutputs execution. Rather than making reviewer selection a special inline field on
create-pull-request, this change adds composable temporary PR references:create-pull-requestreturns and persists a server-generated#aw_...temporary ID.update-properation accepts either a numeric PR ID or a same-job temporary ID.update-pr add-reviewersoperation with default-denyallowed-reviewersand a separatemax-reviewerslimit.addedandfailedarrays, while policy and reference failures remain hard failures.create-pull-request.reviewersremain unchanged.Temporary IDs resolve in NDJSON proposal order and only within one SafeOutputs job. Automatic and manually reviewed outputs run in separate jobs and therefore cannot share temporary references.
Test plan
update-prrequest.cargo test --all-targets.cargo clippy --all-targets.