Repository navigation
Compensate NetFlow/IPFIX export loss from the start of a session - #22
Merged
Merged
Conversation
The loss multiplier stayed at 1 until a 30 s window had elapsed, and it only applies to records decoded afterwards, so short or newly lossy runs were left far below the true totals (about 18% low after 60 s at 37% loss). Compute the first multiplier as soon as 100 records have been seen and refresh it every 5 s; the halving decay and the cap at 2 are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loss compensation used to wait for a 30 s window before computing the multiplier, and the multiplier only applies to records decoded afterwards. Records that arrived during a lossy start were never scaled, so a 60 s run at 37% export loss ended ~18% low.
Changes (internal/decode/nf/decoder.go, updateComp):
Test: TestLossCompensatedFromStart simulates IPFIX with 37% random message loss; compensated/true over the whole run:
A lossless run stays exactly 1.0; the existing reorder and 10%-loss tests still pass. No version bump.