fix: exclusive mkdir so concurrent create-new-feature cannot overwrite spec.md - #4310
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: exclusive mkdir so concurrent create-new-feature cannot overwrite spec.md#4310BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Reserve FEATURE_DIR with exclusive mkdir so a lost race rescans instead of clobbering spec.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create-new-featurepicks the next sequential spec number, checks thatFEATURE_DIRis absent, then creates it withmkdir -p(bash),New-Item -Force(PowerShell), orPath.mkdir(exist_ok=True)(Python). Those creates are not exclusive.Two concurrent invocations can therefore scan the same max number, both pass the exists check, both create the same directory, and the second write clobbers
spec.md.Fix
Create
FEATURE_DIRexclusively. OnEEXIST, rescanspecs/for the next sequential number and retry before writingspec.md. Timestamp mode still errors on collision, matching the previous exists-check behavior.Fixes #4270