Repository navigation
Remove unsupported project Docker default - #19
Open
ronniegeraghty wants to merge 2 commits into
Open
ronniegeraghty wants to merge 2 commits into
ronniegeraghty wants to merge 2 commits into
Conversation
Restore the native local backend by omitting advanced project defaults, remove mandatory Docker CI preparation, and retain the pinned host launcher, model configuration and credential regression checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The README still requires Docker for paid repository evaluations despite this change removing that dependency, leaving the setup instructions inconsistent.
1 open issue
What changed in this PR
Removes the unsupported project-level Docker default from the shared eval configuration, allowing native Vally to select local host execution.
Changes:
- Removes Docker backend settings and workflow prerequisites, restoring the repository-pinned host Copilot launcher.
- Updates execution, authentication and model guidance to explain host execution and exposure limits.
- Replaces Docker-specific regressions with local-default and supported-project-field checks while preserving credential coverage.
| File | Description |
|---|---|
README.md |
Updates paid-eval guidance for local execution. |
docs/checks-and-evals.md |
Documents compatibility, host execution and scoped authentication. |
.vally.yaml |
Removes Docker backend and grading-network defaults. |
.github/workflows/evals.yml |
Restores the host Copilot launcher and removes Docker readiness checks. |
.github/scripts/backend-defaults.test.mjs |
Checks local backend inheritance and supported configuration fields. |
Review effort: Max (dynamic)
Keep the Requirements checklist consistent with native local eval execution. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
The single README prerequisite finding from review 1 is addressed in 🤖 AI-authored reply via Agency Finish PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove the project Docker-backend default that the GitHub Copilot Evals tools do not support yet. With no override, native Vally 0.21.0 selects its local host backend.
defaults.backendand its Docker-specificgrade-networkargument from.vally.yaml.This is separate from #15. Dependency pins/lock, standard models, plugin sources, evals, behavior graders, fixtures and historical saved evidence are unchanged. No unrelated complexity proposals are included.
Compatibility and exposure
The installed Evals plugin 0.24.6 full-engine reader accepts project roots
paths,suites,environments,params,metadata, but rejectsdefaults. A source-grounded before/after check rejectsdefaultsbefore this patch and no root fields afterward; the full-engine environment supports the retained shared setup commands.This intentionally restores local execution, not a Docker-failure fallback. Tasks, setup and graders run on the host. Workspaces and narrow credentials are not filesystem, credential, network or shared-kernel isolation. Existing run/permission/cost approval requirements remain; no authentication or organization/repository settings change.
Validation
--dry-runproduces 14 plans across seven retained evals and two unchanged models.localwith no backend arguments for every retained eval; dependency versions and CLI aliases are unchanged.Published head:
0f51091716f3111389b8c4e38b18e2f4c2c4160f. CI and completed latest-head Copilot review will be collected before handing back; no merge is authorized.