Repository navigation
fix: make jd license URL deterministic before grouping reports - #3534
Open
IrynaKulakova wants to merge 2 commits into
Open
IrynaKulakova wants to merge 2 commits into
IrynaKulakova wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 66177876-e733-4a86-b7bc-236e5d06cbf7
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow rewrite matches the pinned dependency, the reports are consistent, and validation remains enforced.
No open issues 🎉
What changed in this PR
Makes jd/v2 license URLs deterministic so identical architecture reports group consistently.
Changes:
- Normalize the verified
v2.5.0URL before sorting and hashing. - Refresh platform reports without changing license validation or workflow notifications.
| File | Description |
|---|---|
| third-party-licenses.windows.md | Uses the canonical license URL. |
| third-party-licenses.linux.md | Uses the canonical license URL. |
| third-party-licenses.darwin.md | Uses the canonical license URL. |
| script/licenses | Normalizes the version-specific URL before grouping. |
Review effort: Max
JoannaaKL
reviewed
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the inconsistent
jd/v2license URL before sorting and hashing architecture reports, preventing spurious license-check failures. Regenerate the Darwin, Linux, and Windows reports with the canonical URL.Why
Addresses the review feedback on #3490. The failed job split otherwise identical Windows architecture reports because
go-licensesemitted different license URLs for the same dependency; making notification failures nonfatal does not fix that mismatch.What changed
https://github.com/josephburnett/jd/blob/v2.5.0/v2/LICENSEto the verified repository-root license URL before sorting and hashing. This is a version-specific workaround, not a general rewrite of/v2/paths.MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint-script/lintpassed with 0 issues../script/test-script/testpassed, including race tests.Additional validation:
PATH="$(go env GOPATH)/bin:$PATH" script/licenses- passed twice; SHA-256 comparisons confirmed identical reports and all saved license files across consecutive runs.bash -n script/licenses- passed.git diff --check- passed.Docs