README: GITHUB_TOOLSETS doesn't take precedence over --toolsets (viper gives the flag priority)

The README says:
"The environment variable GITHUB_TOOLSETS takes precedence over the command line argument if both are provided."

github-mcp-server/README.md

Line 468 in f385262

    
           The environment variable `GITHUB_TOOLSETS` takes precedence over the command line argument if both are provided.

--toolsets is bound through viper, and the env is wired with AutomaticEnv:

github-mcp-server/cmd/github-mcp-server/main.go

Line 280 in f385262

_ = viper.BindPFlag("toolsets", rootCmd.PersistentFlags().Lookup("toolsets"))

github-mcp-server/cmd/github-mcp-server/main.go

Lines 313 to 317 in f385262

    
           	// Initialize Viper configuration 
        
           	viper.SetEnvPrefix("github") 
        
           	viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_")) 
        
           	viper.AutomaticEnv() 
        
           }

github-mcp-server/cmd/github-mcp-server/main.go

Lines 87 to 90 in f385262

    
           if viper.IsSet("toolsets") { 
        
           	if err := viper.UnmarshalKey("toolsets", &enabledToolsets); err != nil { 
        
           		return fmt.Errorf("failed to unmarshal toolsets: %w", err) 
        
           	}

Viper's lookup order is Set() > flag (if changed) > env > config > default, so when both are given the flag wins, the opposite of the README. That matters a bit for anyone trying to narrow toolsets via env on top of a launcher that already passes --toolsets. Probably just the README sentence that needs flipping.

Found while testing a docs-vs-code checker I'm building (Elliot), then verified by hand.

Navigation Menu

Repository navigation

README: GITHUB_TOOLSETS doesn't take precedence over --toolsets (viper gives the flag priority) #3578

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Initialize Viper configuration
	viper.SetEnvPrefix("github")
	viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
	viper.AutomaticEnv()
	}

	if viper.IsSet("toolsets") {
	if err := viper.UnmarshalKey("toolsets", &enabledToolsets); err != nil {
	return fmt.Errorf("failed to unmarshal toolsets: %w", err)
	}

README: GITHUB_TOOLSETS doesn't take precedence over --toolsets (viper gives the flag priority) #3578

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions