Repository navigation
Prepare git-sizer for a new release built with Go 1.27.3 - #165
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The four replacement vendored-toolchain SHA-256 values could not be verified against official Go 1.27.3 download metadata and need confirmation before the fallback installer is relied on for release builds.
No open issues 🎉
What changed in this PR
Prepares git-sizer for releases built with Go 1.27.3, improves Linux binary compatibility, and aligns release naming and documentation with the automated workflow.
Changes:
- Disables cgo for release builds and strips the tag’s leading
vfrom release versions. - Updates CI and fallback Go installers, adds Linux ARM64 installer support, and removes the macOS runner workaround.
- Documents the tag-triggered draft release process.
| File | Description |
|---|---|
script/install-vendored-go |
Updates Go version and checksums; adds Linux ARM64 support. |
script/ensure-go-installed.sh |
Updates fallback Go and installed-version acceptance checks. |
Makefile |
Disables cgo for release platform builds. |
docs/RELEASING.md |
Documents automated draft release creation. |
.github/workflows/test.yml |
Updates Go and uses the standard matrix runners. |
.github/workflows/release.yml |
Updates Go setup and normalizes release versions. |
Review effort: Balanced (auto)
Cross-compiled release targets already disable cgo implicitly, but the native host target (linux/amd64 on ubuntu-latest) defaults to CGO_ENABLED=1 and links against GLIBC_2.34, which fails on older systems like Ubuntu 20.04 (GLIBC_2.31). Force CGO_ENABLED=0 for all release targets so every archive ships a static binary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
GITHUB_REF_NAME includes the tag's leading "v" (e.g. "v1.6.0"), whereas
Makefile expects a bare version ("1.6.0"). Strip the prefix so archive
names and "--version" output match prior releases (v1.0.0-v1.5.0) and
downstream packaging URLs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
Raise the fallback vendored Go version from 1.21.3 to 1.27.3 (and add linux/arm64 checksums) to pick up Go stdlib security fixes such as CVE-2026-111943, while still accepting installed Go 1.26.10+. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
Build releases and run CI tests with Go 1.27.3 instead of Go 1.21 so published binaries include current Go stdlib security fixes (CVE-2026-111943). Also drop the macos-15 runner pin that was only needed for Go 1.21 linker output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
Pushing a "v*" tag now builds the platform archives and creates a draft release via release.yml instead of requiring manual local uploads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
larsxschneider
force-pushed
the
ls/git-sizer-release
branch
from
November 12, 2026 12:56
56ebb20 to
9305a30
Compare
torstenwalter
previously approved these changes
Nov 12, 2026
Drop the third-party softprops/action-gh-release dependency (whose v1 tag still uses the deprecated node16 runtime) in favor of the preinstalled GitHub CLI on ubuntu-latest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5946d63-5054-4db7-8484-2db48414dc6e
torstenwalter
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare
git-sizerfor a new release built with Go 1.27.3:cgofor release builds (CGO_ENABLED=0): Nativelinux/amd64builds onubuntu-latestotherwise link dynamically againstGLIBC_2.34vianet/runtime/cgoand fail on older Linux distributions (e.g. Ubuntu 20.04 withGLIBC_2.31).vfromGITHUB_REF_NAMEinrelease.yml: Pushing tagv1.6.0setsGITHUB_REF_NAME=v1.6.0, whereasMakefileexpectsVERSION=1.6.0so archive filenames (git-sizer-1.6.0-<os>-<arch>.zip) andgit-sizer --versionmatch prior releases (v1.0.0–v1.5.0).1.27.3: Updatetest.yml,release.yml, and the fallback vendored Go scripts (script/ensure-go-installed.sh,script/install-vendored-go) from Go 1.21 to Go 1.27.3 (while continuing to accept installed Go1.26.10+), and drop the Go 1.21macos-15runner workaround.softprops/action-gh-releasewithgh release create: Drop the third-partynode16action inrelease.ymlin favor of the preinstalled GitHub CLI onubuntu-latest(this way we can close Bump softprops/action-gh-release from 1 to 2 #164 )docs/RELEASING.md: Reflect the automated draft release workflow triggered by pushing av*tag.