[ericyan]

Summary

• Return cleanup errors from fresh move-tables migrations and noop runs instead of reporting success, preserving the existing resumed-cutover behavior.
• Warn that a failure hook can run after target writes may have been enabled; do not assume recovery is safe without inspecting state.
• Cover fresh and resumed cutovers, noop cleanup, and CLI failure-hook dispatch with focused integration tests.

Validation

• go test -race -v ./go/logic -run '^TestMoveTablesCleanupErrors$' -count=1
• go test -short -v ./go/logic -run '^TestMoveTablesCleanupErrors$' -count=1 (skipped as intended)
• golangci-lint run ./go/logic/...
• Verified that the fresh real and noop regression tests fail against the pre-fix code.

Stacked on #1755. The separate completed-transaction frontier issue #1781 remains unresolved.

[Copilot]

🟡 Changes recommended

The integration test can block until timeout if MoveTables() returns before onBeforeCutOver runs, masking the underlying migration error.

1 open issue

• Bound progress wait to expose migration errors · New

What changed in this PR

This PR makes move-tables migrations report cleanup failures instead of success, while preserving existing resumed-cutover behavior.

Changes:

• Return contextual cleanup errors for fresh real and noop migrations.
• Add integration coverage for fresh, resumed, and noop cleanup failures, plus CLI failure-hook dispatch.
• Document that failure hooks may run before startup or after target writes have been enabled.

File	Description
go/​logic/​migrator.go	Propagates fresh move-tables cleanup errors with mode-specific context.
go/​logic/​migrator_move_tables_cleanup_integration_test.go	Tests cleanup error propagation, warnings, and CLI failure hooks.
doc/​hooks.md	Clarifies failure-hook timing and cautions against blind rollback.

_{Review effort: Max (auto)}

The merge-base changed after approval.