Skip to content

[code-scanning-fix] Fix js/incomplete-multi-character-sanitization: HTML injection bypass in stripMarkdown #46441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 4 commits into from
+19 −9
Closed

[code-scanning-fix] Fix js/incomplete-multi-character-sanitization: HTML injection bypass in stripMarkdown #46441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ced8497
fix: use single-character replacement in stripMarkdown to prevent HTM…
github-actions[bot] Jul 18, 2026
bf28830
plan: refine stripMarkdown fix to use loop-based HTML tag removal
Copilot Jul 18, 2026
2362542
fix: use loop-based HTML tag stripping in stripMarkdown to preserve m…
Copilot Jul 18, 2026
a77f470
fix: add iteration limit to loop-based HTML tag stripping in stripMar…
Copilot Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agentic-auto-upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ name: Agentic Auto-Upgrade

on:
schedule:
- cron: "21 3 * * 5" # Weekly (auto-upgrade)
- cron: "11 4 * * 6" # Weekly (auto-upgrade)
workflow_dispatch:

permissions:
Expand Down
13 changes: 9 additions & 4 deletions docs/scripts/sync-workshop-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,19 @@ function loadLocalWorkshopEntries(sourceDir) {
}

function stripMarkdown(value) {
return String(value)
let str = String(value)
.replace(/!\[([^\]]*)\]\([^)]+\)/gu, '$1')
.replace(/\[([^\]]+)\]\([^)]+\)/gu, '$1')
.replace(/`([^`]+)`/gu, '$1')
.replace(/\*\*([^*]+)\*\*/gu, '$1')
.replace(/_([^_]+)_/gu, '$1')
.replace(/<[^>]+>/gu, '')
.trim();
.replace(/_([^_]+)_/gu, '$1');
let prev;
let iterations = 0;
do {
prev = str;
str = str.replace(/<[^>]+>/gu, '');
} while (str !== prev && ++iterations < 20);
return str.trim();
}

function extractTitle(body, fallbackId) {
Expand Down
13 changes: 9 additions & 4 deletions docs/src/lib/workshop/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,19 @@ function normalizeStepId(fileName: string) {
}

function stripMarkdown(value: string) {
return String(value)
let str = String(value)
.replace(/!\[([^\]]*)\]\([^)]+\)/gu, '$1')
.replace(/\[([^\]]+)\]\([^)]+\)/gu, '$1')
.replace(/`([^`]+)`/gu, '$1')
.replace(/\*\*([^*]+)\*\*/gu, '$1')
.replace(/_([^_]+)_/gu, '$1')
.replace(/<[^>]+>/gu, '')
.trim();
.replace(/_([^_]+)_/gu, '$1');
let prev;
let iterations = 0;
do {
prev = str;
str = str.replace(/<[^>]+>/gu, '');
} while (str !== prev && ++iterations < 20);
return str.trim();
}

function parseCurriculumRows(readmeBody: string): CurriculumRow[] {
Expand Down
Loading