Disambiguate internal test-helper exports across six modules

[Copilot]

The codebase exported testHelpers from six different modules, creating avoidable naming collisions and forcing import aliasing in tests. This change makes each test-only helper export module-specific so import intent is explicit and collision-free.

• API surface cleanup (test-only exports)

  • host-iptables-shared.ts → iptablesSharedTestHelpers
  • copilot-api-resolver.ts → copilotApiResolverTestHelpers
  • host-env.ts → hostEnvTestHelpers
  • container-lifecycle.ts → containerLifecycleTestHelpers
  • host-iptables-network.ts → iptablesNetworkTestHelpers
  • logs/log-discovery.ts → logDiscoveryTestHelpers

• Consumer updates (tests)

  • Updated all affected unit tests to import the new names directly.
  • Removed now-unnecessary aliasing where imports were only aliased to avoid testHelpers collisions.

• Resulting pattern

  • Test-only exports are now self-describing at import sites and no longer conflict when multiple helper modules are used together.

// Before
import { testHelpers as networkTestHelpers } from './host-iptables-network';
import { testHelpers } from './host-iptables-shared';

// After
import { iptablesNetworkTestHelpers } from './host-iptables-network';
import { iptablesSharedTestHelpers } from './host-iptables-shared';

[github-actions]

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	96.54%	96.58%	📈 +0.04%
Statements	96.38%	96.42%	📈 +0.04%
Functions	97.99%	97.99%	➡️ +0.00%
Branches	90.78%	90.82%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
src/config-writer.ts	89.3% → 90.9% (+1.65%)	89.3% → 90.9% (+1.65%)

---

Coverage comparison generated by scripts/ci/compare-coverage.ts

[Copilot]

Pull request overview

This PR removes ambiguous testHelpers exports from several internal modules by renaming them to module-specific *TestHelpers exports, and updates all impacted unit tests to import the new names directly—eliminating naming collisions and unnecessary aliasing in test code.

Changes:

• Renamed test-only helper export objects to module-specific names (e.g., logDiscoveryTestHelpers, iptablesSharedTestHelpers, etc.).
• Updated all affected unit tests to use the new export names and removed collision-driven import aliasing where it was only used to disambiguate testHelpers.
• Kept the helpers explicitly marked as @internal / test-only while making import intent clearer at call sites.

Show a summary per file

File	Description
src/logs/log-discovery.ts	Renames testHelpers export to logDiscoveryTestHelpers.
src/logs/log-discovery.test.ts	Updates imports/usages to logDiscoveryTestHelpers.
src/host-iptables-shared.ts	Renames testHelpers export to iptablesSharedTestHelpers.
src/host-iptables-shared.test.ts	Updates imports/usages to iptablesSharedTestHelpers.
src/host-iptables-setup.test.ts	Updates imports/usages to iptablesSharedTestHelpers.
src/host-iptables-network.ts	Renames testHelpers export to iptablesNetworkTestHelpers.
src/host-iptables-network.test.ts	Updates imports/usages to iptablesNetworkTestHelpers and iptablesSharedTestHelpers; removes aliasing.
src/host-iptables-host-access.test.ts	Updates imports/usages to iptablesSharedTestHelpers.
src/host-iptables-doh.test.ts	Updates imports/usages to iptablesSharedTestHelpers.
src/host-iptables-cleanup.test.ts	Updates imports/usages to iptablesSharedTestHelpers.
src/host-env.ts	Renames testHelpers export to hostEnvTestHelpers.
src/docker-manager-utils.test.ts	Updates imports/usages to hostEnvTestHelpers.
src/docker-manager-lifecycle.test.ts	Updates imports/usages to containerLifecycleTestHelpers (removes aliasing).
src/copilot-api-resolver.ts	Renames testHelpers export to copilotApiResolverTestHelpers.
src/copilot-api-resolver.test.ts	Updates imports/destructuring to copilotApiResolverTestHelpers.
src/container-lifecycle.ts	Renames testHelpers export to containerLifecycleTestHelpers.
src/cli.test.ts	Updates imports to copilotApiResolverTestHelpers without aliasing.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 17/17 changed files
• Comments generated: 0

[github-actions]

Smoke Test: Claude Engine

• ✅ GitHub API: 2 recent PRs fetched
• ✅ GitHub check (playwright): PASS
• ✅ File verify: smoke-test-claude-26425126880.txt present

Result: PASS

💥 [THE END] — Illustrated by Smoke Claude

[github-actions]

🔬 Smoke Test Results

Test	Result
GitHub MCP connectivity	✅ PR data fetched successfully
GitHub.com HTTP connectivity	⚠️ N/A (template vars not expanded)
File write/read	⚠️ N/A (template vars not expanded)

PR: "Disambiguate internal test-helper exports across six modules" by @Copilot, assigned to @lpcox and @Copilot.

Overall: PARTIAL — MCP test passed; pre-step smoke data was not injected (unexpanded ${{ }} template variables).

📰 BREAKING: Report filed by Smoke Copilot

[github-actions]

Smoke Test: Copilot BYOK (Offline) Mode

Test	Result
GitHub MCP connectivity	✅ PR list returned successfully
GitHub.com HTTP check	⚠️ Pre-step data not expanded (template var unexpanded)
File write/read	⚠️ Pre-step data not expanded (template var unexpanded)
BYOK inference (api-proxy → api.githubcopilot.com)	✅ Responding via BYOK offline mode

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PARTIAL — BYOK inference and MCP working; pre-step smoke data template vars were not substituted.

PR author: @Copilot | Assignees: @lpcox, @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

[github-actions]

fix(api-proxy): prevent stream_options injection into OpenAI Responses API requests ✅
Filter unresolvable model aliases from /reflect and models.json ✅
Build ✅
Browser ✅
File ✅
PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

[github-actions]

Chroot Runtime Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.15.0	v22.22.3	❌
Go	go1.22.12	go1.22.12	✅

Result: Not all tests passed — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3826 · sonnet46 992.7K · ◷

[github-actions]

Smoke Test Results: FAIL

Check	Result
Redis PING	❌ Timeout/no response
PostgreSQL pg_isready	❌ No response
PostgreSQL SELECT 1	❌ Timeout/no response

host.docker.internal is unreachable from this environment — service containers are not accessible.

🔌 Service connectivity validated by Smoke Services

[github-actions]

Smoke test FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

[lpcox]

@copilot address review feedback

[Copilot]

@copilot address review feedback

I checked the PR review output and there are currently no actionable review comments/threads (the Copilot review reported “Comments generated: 0”). Please point me to the specific feedback you want addressed, and I’ll apply it immediately.