Repository navigation
Conversation
Add an is_retry request option that sends the X-Is-Retry: true header, and an opt-in mark_timeout_retries throttler option that sets it only on checks repeating a check for the same store that timed out or got an HTTP 408 response. Re-checks after a throttled answer are polling and stay unmarked. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the opt-in timeout retry marking changes.
No open issues 🎉
What changed in this PR
Adds opt-in retry marking so load balancers can distinguish throttler checks repeated after timeouts from normal polling. Existing behavior remains the default.
Changes:
- Adds the
is_retryrequest option to sendX-Is-Retry: true. - Adds
mark_timeout_retriesto track timeout retries per store and perthrottlecall. - Documents both options and adds tests for header behavior, reset, isolation, and defaults.
| File | Description |
|---|---|
test/freno/throttler_retry_header_test.rb |
Tests timeout retry marking, polling, isolation, and defaults. |
test/freno/client/requests/check_test.rb |
Tests explicit retry headers and their default omission. |
README.md |
Documents configuration and retry-versus-polling behavior. |
lib/freno/throttler.rb |
Tracks timeout retries and conditionally marks repeated checks. |
lib/freno/client/request.rb |
Adds request-level retry header support. |
lib/freno/client.rb |
Documents the is_retry request option. |
CHANGELOG.md |
Records both options under Unreleased. |
Review effort: Balanced (auto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.