Repository navigation
Conversation
Maintainers could assume a package's complete README license section was captured even when the extractor only accepts a license heading and two specific MIT text markers. Removing that broad assurance avoids treating the guide as evidence for unsupported extraction. https://github.com/github/evals-action/blob/6e4c077e92194c7e75663d8d782426841047e887/tooling/license-notices.mjs#L48-L59 Unresolved entries still block public release and require authoritative terms and release-owner disposition. https://github.com/github/evals-action/blob/6e4c077e92194c7e75663d8d782426841047e887/CONTRIBUTING.md#L80-L85 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change removes an unsupported README license-retention guarantee while preserving the surrounding generated-notice, provenance, and attribution guidance, leaving no active review issues.
No open issues 🎉
What changed in this PR
This documentation-only PR narrows contributor guidance to match the license extractor’s actual behavior, removing an unsupported guarantee that complete license sections from package READMEs are retained in generated notices.
Changes:
- Removes the broad README license-capture guarantee.
- Preserves the existing generated-notice, provenance, and attribution guidance.
| File | Description |
|---|---|
| CONTRIBUTING.md | Removes the overbroad guarantee about retaining complete license sections from package READMEs while preserving the surrounding release guidance. |
Review effort: Lite (auto)
Copilot could add the dedicated token input to an existing environment-based setup because the input table calls it required. The native environment builder accepts the explicit alias and rejects combining it with the dedicated input, so describing the input as supported rather than required avoids that mistaken prerequisite. https://github.com/github/evals-action/blob/6e4c077e92194c7e75663d8d782426841047e887/src/native.ts#L56-L70 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧠 How this helps Copilot
Copilot could assume that every complete license section in a package README appears in the generated notices. The extractor recognizes a narrower format. Removing the broader assurance helps Copilot avoid relying on unsupported license capture during release preparation.
Copilot could also add the dedicated token input to an existing environment-based authentication setup because the input table calls it required. That combination is rejected. Clarifying that the input supports explicit runs avoids implying it is the only supported route.
Review commit by commit for each change's rationale and evidence.
Note
Copilot Dreaming curates this repository's Copilot instructions and skills in the background, proposing updates to help agents work here. Learn more about Copilot Dreaming.
Automated details
Source:
curate-memoriesDream, analyzingmainat6e4c077.