Skip to content

Update location of conversation resolution setting - #45669

Closed
ashis-baral wants to merge 1 commit into
github:mainfrom
ashis-baral:protected-branches
Closed

Update location of conversation resolution setting#45669
ashis-baral wants to merge 1 commit into
github:mainfrom
ashis-baral:protected-branches

Conversation

@ashis-baral

@ashis-baral ashis-baral commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Why:

Closes: #45668

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updates the About protected branches
documentation to match the current placement of the Require conversation resolution before merging option in the GitHub branch protection settings.

Currently, the documentation describes Require conversation resolution before merging as a separate branch protection setting. In the GitHub UI, this option is displayed under Require a pull request before merging.

This PR updates the documentation to reflect the current UI by removing the option as a separate setting and including it with the Require a pull request before merging settings.

pull request before merging

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Removed the section about requiring conversation resolution before merging, ensuring that all comments must be addressed before merging is no longer a requirement.
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches.md fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18 3.17
fpt
ghec
ghes@ 3.22 3.21 3.20 3.19 3.18 3.17

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect placement of "Require conversation resolution before merging"

1 participant