Skip to content

JS: Clarify that memory limit is for Node.js process specifically #23024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paldepind merged 1 commit into from
Nov 5, 2026
+5 −5
Merged

JS: Clarify that memory limit is for Node.js process specifically #23024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/extractor/src/com/semmle/js/extractor/ExtractorConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public Set<String> getPredefinedGlobals() {
/** Should textual information be extracted into the lines/4 relation? */
private boolean extractLines;

/** Override amount of RAM to allocate to the TypeScript compiler. */
/** Override the amount of RAM for the Node.js process. */

@paldepind paldepind Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might make sense and I can look into this is a human agrees, but I think the scope of this PR is just to remove references to the "TypeScript compiler".

private int typescriptRam;

/** The default character encoding to use for parsing source files. */
Expand Down
2 changes: 1 addition & 1 deletion javascript/extractor/src/com/semmle/js/extractor/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ private ArgsParser addArgs(ArgsParser argsParser) {
argsParser.addFlag(
P_TYPESCRIPT_RAM,
1,
"Amount of memory allocated to the TypeScript compiler process. The default is 1G.");
"Amount of memory assigned to the Node.js process's V8 old-space limit. The default is 1G.");
argsParser.addToleratedFlag(P_DEBUG_EXCLUSIONS, 0);
argsParser.addTrailingParam("files", "Files and directories to extract.");
return argsParser;
Expand Down
2 changes: 1 addition & 1 deletion javascript/extractor/src/com/semmle/ts/extractor/TypeScriptParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public class TypeScriptParser {
/** Metadata requested immediately after starting the TypeScript parser. */
private TypeScriptParserMetadata metadata;

/** Sets the amount of RAM to allocate to the TypeScript compiler.s */
/** Sets the amount of RAM for the Node.js process's V8 old-space limit. */
public void setTypescriptRam(int megabytes) {
this.typescriptRam = megabytes;
}
Expand Down
2 changes: 1 addition & 1 deletion javascript/resources/tools/autobuild.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ SETLOCAL EnableDelayedExpansion

set jvm_args=-Xss16m

rem If CODEQL_RAM is set, use half for Java and half for TS.
rem If CODEQL_RAM is set, use half for Java and half for Node.js.
if NOT [%CODEQL_RAM%] == [] (
set /a "half_ram=CODEQL_RAM/2"
set LGTM_TYPESCRIPT_RAM=!half_ram!
Expand Down
2 changes: 1 addition & 1 deletion javascript/resources/tools/autobuild.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -eu

jvm_args=-Xss16m

# If CODEQL_RAM is set, use half for Java and half for TS.
# If CODEQL_RAM is set, use half for Java and half for Node.js.
if [ -n "${CODEQL_RAM:-}" ] ; then
half_ram="$(( CODEQL_RAM / 2 ))"
LGTM_TYPESCRIPT_RAM="$half_ram"
Expand Down
Loading