C++: Support sizeof VLAs in the IR#20319
Merged
Merged
Conversation
* Introduce new instruction tag for the base size * Introduce some convenience predicates on `VlaDeclStmt`
jketema
force-pushed
the
ir-vla-sizeof
branch
from
3d6f91a to
bd98363
Compare
jketema
force-pushed
the
ir-vla-sizeof
branch
from
bd98363 to
9431b0c
Compare
MathiasVP
reviewed
Sep 2, 2025
MathiasVP
left a comment
MathiasVP
left a comment
Contributor
There was a problem hiding this comment.
A couple of comments, but otherwise this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review recommended.