Repository navigation
Make the "All-platform bundle" PR check use the all-platform bundle - #4312
Open
henrymercer wants to merge 3 commits into
Open
henrymercer wants to merge 3 commits into
henrymercer wants to merge 3 commits into
Conversation
…test` Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ndle Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…rm-bundle` Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The bundle check uses POSIX dirname on a Windows backslash path, incorrectly checking ./tools and potentially failing Windows PR checks for valid bundles.
1 open issue
What changed in this PR
This PR restores all-platform nightly bundle coverage in the CodeQL Action’s PR checks without changing production behavior.
Changes:
- Resolve an explicit all-platform nightly bundle URL when requested by
prepare-test. - Add a check for Linux, macOS, and Windows tool directories.
- Remove the redundant “CodeQL Bundle All” workflow and its deflake registration.
| File | Description |
|---|---|
pr-checks/checks/all-platform-bundle.yml |
Adds validation that the bundle contains tools for all three platforms. |
.github/workflows/test-codeql-bundle-all.yml |
Removes the redundant standalone check. |
.github/workflows/deflake.yml |
Removes the deleted workflow’s retry registration. |
.github/workflows/__all-platform-bundle.yml |
Mirrors the template’s validation step in the generated workflow. |
.github/actions/prepare-test/action.yml |
Resolves the latest nightly all-platform bundle URL when requested. |
Review effort: Balanced (auto)
henrymercer
marked this pull request as ready for review
November 9, 2026 17:58
|
Chelbi Denny
…On Mon, Nov 9, 2026, 10:58 AM Henry Mercer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pr-checks/checks/all-platform-bundle.yml
<#4312 (comment)>
:
> @@ -17,6 +17,18 @@ steps:
# Swift is not supported on Ubuntu so we manually exclude it from the list here
languages: cpp,csharp,go,java,javascript,python,ruby
tools: ${{ steps.prepare-test.outputs.tools-url }}
+ - name: Check that the bundle contains tools for all platforms
+ env:
+ CODEQL_PATH: ${{ steps.init.outputs.codeql-path }}
+ run: |
+ # Platform-specific bundles only contain the tools for their own platform.
+ tools_dir="$(dirname "$CODEQL_PATH")/tools"
I think Git Bash's dirname handles this situation, and indeed the Windows
job passed.
—
Reply to this email directly, view it on GitHub
<#4312?email_source=notifications&email_token=BUZOJV4LUMRZJFJIU5GDULD5YIATPA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKOBTGAZDSNZUG42KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussion_r4516099464>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUZOJV4VHHRBFNOFZQFQ4QD5YIATPAVCNFSNUABFKJSXA33TNF2G64TZHMZDKOJUGQ2TQNZYHNEXG43VMU5TMMRZGEZTGNZQGY2KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BUZOJV4OVWODJEYVQFBENGL5YIATPA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKOBTGAZDSNZUG42KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/BUZOJV2AL2DCCGF2PUVOHKT5YIATRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKOBTGAZDSNZUG42KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "All-platform bundle" and "CodeQL Bundle All" PR checks are meant to test the all-platform CodeQL bundle. Since #3130, though,
prepare-testhas returnednightlyas the tools URL fornightly-latestregardless ofuse-all-platform-bundle, so both checks have been testing the platform-specific nightly bundles.This PR makes
prepare-testlook up the latest nightly release and return the URL of its all-platform bundle whenuse-all-platform-bundleis set. It also adds a step to the "All-platform bundle" check that fails unless the bundle contains tools for Linux, macOS and Windows, so that this can't silently regress.The Ubuntu job of "All-platform bundle" covers everything that "CodeQL Bundle All" tests, so this PR removes "CodeQL Bundle All".
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
CodeQL Bundle All (ubuntu-26.04, nightly-latest)is a required check, so it needs removing from the required checks withpr-checks/sync-checks.tsbefore this PR can merge.Merge / deployment checklist