Repository navigation
Remove macos-14-xlarge from codeql workflow - #4309
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Although the workflow diff is straightforward, safe merging requires removing both macos-14 matrix contexts from external branch-protection required checks, which cannot be verified from the checked-in files.
No open issues 🎉
What changed in this PR
Removes the unsupported macos-14-xlarge runner from the CodeQL JavaScript analysis matrix, preventing required merge-queue checks from failing.
Changes:
- Removes
macos-14-xlargefrom theanalyze-javascriptoperating-system matrix. - Retains Ubuntu, Windows, and
macos-15-xlargecoverage. - Required-check configuration must be synchronized separately.
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Removes the unsupported macOS 14 runner from the CodeQL analysis matrix. |
Review effort: Lite (auto)
|
Should we add macos-26? |
I plan to rework the checks so we make sure each runner image is tested, but not necessarily on the JS analysis for this repo. I'll do that in a separate PR though so we can unblock CI faster. (Note for instance that Swift analysis on macos-26 is already covered by this check: https://github.com/github/codeql-action/actions/runs/42269788821/job/128071063024?pr=4309) |
The
analyze-javascript (macos-14-xlarge)jobs in thecodeqlworkflow are now cancelled with "The configuration 'macos-14-arm64-us-xl' is not supported". These are required checks, so every PR in the merge queue is failing. This PR removesmacos-14-xlargewithout a replacement, since many other PR checks already run on macOS 26. A follow-up PR will look at the overall PR check coverage across runner images.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
pr-checks/sync-checks.tsbefore it can merge. The release branches will pick up the workflow change in the next release, as they did for Removemacos-13fromcodeqlworkflow #3274.Merge / deployment checklist