Skip to content

sap-cloud-integration: link public SAP Help Portal and SAP Architecture Center pages - #6398

Merged
aaronpowell merged 2 commits into
github:mainfrom
rameshvaranganti:sap-cloud-integration-public-links
Nov 13, 2026
Merged

aaronpowell merged 2 commits into
github:mainfrom
rameshvaranganti:sap-cloud-integration-public-links

Conversation

@rameshvaranganti

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Follow-up to #6363. Replaces GitHub links to SAP-docs Markdown sources with the public SAP Help Portal pages (using SAP's stable topic IDs, the same form SAP uses in its own cross-references) and points SAP Architecture Center to https://architecture.learning.sap.com/. Adds a rule to cite public SAP pages to users. No behavior guidance changed.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: ⏳ Awaiting automation

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Changes 70 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ⏳ Pending Running · logs
Generated README consistency ⏳ Pending Running · logs
Skill validation ⏳ Pending Running · logs
Skill lint (vally) ⏳ Pending Running · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for e12f634 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 2 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added the skills PR touches skills label Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change still has three active documentation-link wording issues that can prevent valid citations to SAP Business Accelerator Hub and overstate stable Help Portal topic-link coverage.

3 open issues
What changed in this PR

Updates the SAP Cloud Integration skill to use public SAP Help Portal and SAP Architecture Center links for user-facing citations while retaining GitHub as a searchable documentation source.

Changes:

  • Replaces SAP documentation Markdown links with SAP Help Portal topic URLs.
  • Updates the SAP Architecture Center reference to architecture.learning.sap.com.
  • Adds guidance for citing public SAP sources.
File Description
skills/​sap-cloud-integration/​SKILL.md Updates authoritative-source links and citation guidance for the SAP Cloud Integration skill.
skills/​sap-cloud-integration/​references/​sap-documentation-index.md Replaces Cloud Integration GitHub documentation links with public SAP Help Portal references and updates source descriptions.

Review effort: Lite (dynamic)

Comment thread skills/sap-cloud-integration/SKILL.md Resolved
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ sap-cloud-integration (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/sap-cloud-integration
✅ sap-cloud-integration (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 13, 2026
Copilot AI dynamic review requested due to automatic review settings November 13, 2026 02:54
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change updates 29 SAP Help Portal topic URLs plus the Architecture Center URL, requiring maintainer spot-checks because the restricted environment cannot verify that the new IDs reach the intended public pages.

No open issues 🎉

3 resolved since last review

Review effort: Lite (dynamic)

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the SAP Cloud Integration skill's source links. references/sap-documentation-index.md now points users to SAP Help Portal topic pages and the public SAP Architecture Center, and the skill explicitly tells Copilot not to cite the GitHub Markdown mirror. This gives users direct links to SAP's public documentation.

@aaronpowell
aaronpowell merged commit ee814bb into github:main Nov 13, 2026
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants