Skip to content

Add exact-file CAD manufacturing handoff skill 🤖🤖🤖 - #6340

Closed
KanishkVashisht wants to merge 1 commit into
github:mainfrom
KanishkVashisht:feat/cad-manufacturing-handoff
Closed

KanishkVashisht wants to merge 1 commit into
github:mainfrom
KanishkVashisht:feat/cad-manufacturing-handoff

Conversation

@KanishkVashisht

Copy link
Copy Markdown

Description

Adds an exact-file CAD manufacturing handoff skill for the point after a coding agent has produced an export. It preserves artifact hashes, declared units, physical component quantities, manufacturing requirements and measured evidence; it also handles ambiguous submissions without duplicating requests. This complements the existing freecad-scripts modeling skill.

The core workflow works locally and preserves the user's selected provider. A separate, opt-in partsforagents reference documents its actual MCP/REST contract, required inputs, retention limits and nonbinding request states. The skill does not accept offers, pay or operate printers.

Draft: native GitHub Copilot runtime validation is pending. No usable local Copilot runtime/credential was available. The independent agent test below is not presented as a Copilot test.

Validation

  • npm ci --ignore-scripts completed; no dependency/lockfile changes.
  • npm run skill:validate: all 461 skills valid.
  • npm run plugin:validate: all 110 local plugins and the external catalog valid.
  • npm run build: generated the single new skill README row; no other generated changes.
  • Skill-creator quick_validate.py: passed in an isolated Python environment.
  • Ran bash eng/fix-line-endings.sh; its GNU sed -i invocation is incompatible with this macOS host. Applied the equivalent CRLF-to-LF normalization to the four contribution files, verified LF-only content and passed git diff --check.
  • Independent Codex-agent forward test using local synthetic CAD: detected 42 x 20 x 3 mm and two disconnected components against an approved 40 x 20 x 3 mm/one-body requirement; preserved the requested provider/specification and exact file hash; reported unresolved questions without uploading, making a record or claiming printability. No customer data or service transaction was involved.

Pull Request Checklist

  • Read the contribution guidelines and paid-service submission guidance.
  • New skill files are in the correct directory, with valid metadata and naming.
  • Content is focused and structured; references are linked from SKILL.md.
  • Tested with GitHub Copilot — pending; this PR remains a draft.
  • Ran the repository build and verified generated documentation.
  • Targeting main.

Type of Contribution

  • New skill.

Disclosure

I am affiliated with partsforagents. This contribution was authored and reviewed with AI assistance. The optional adapter covers a service with free advice and nonbinding request intake; manufacturing is a separately offered paid service. It contains no promotion, coupon, referral link, or default provider selection.

This contribution follows the repository Code of Conduct and is offered under its MIT License.

@github-actions github-actions Bot added new-submission PR adds at least one new contribution skills PR touches skills labels Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 3 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Adds 3 file(s), e.g. skills/cad-manufacturing-handoff/SKILL.md
  • Changes 256 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for b1f0b80 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ cad-manufacturing-handoff (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/cad-manufacturing-handoff
✅ cad-manufacturing-handoff (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 10, 2026
@aaronpowell

Copy link
Copy Markdown
Contributor

Thanks for contributing this workflow. The local, provider-neutral handoff guidance is useful, but the submitted skill also includes a provider adapter: references/provider.md discloses your affiliation with partsforagents and documents its MCP endpoint and manufacturing-order API. The upstream README promotes FDM job submission with payment after review and a time-limited discount. As submitted, that makes this a path into an affiliated commercial service. Please consider contributing the provider-neutral handoff workflow separately, without the partsforagents adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium new-submission PR adds at least one new contribution ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants