Skip to content

fix(gdpr-compliant): repair reference paths that fail on case-sensiti… - #6339

Merged
aaronpowell merged 2 commits into
github:mainfrom
ClarrieO5:fix-gdpr-compliant-reference-paths
Nov 11, 2026
Merged

aaronpowell merged 2 commits into
github:mainfrom
ClarrieO5:fix-gdpr-compliant-reference-paths

Conversation

@ClarrieO5

@ClarrieO5 ClarrieO5 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

…ve file systems

SKILL.md pointed to references/security.md (file was Security.md) and to references/operations.md (never existed; its cloud, CI/CD, incident and architecture sections live in Security.md). Rename the file to the lowercase name the skill already uses and fold the operations entry into it.

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

…ve file systems

SKILL.md pointed to references/security.md (file was Security.md) and to
references/operations.md (never existed; its cloud, CI/CD, incident and
architecture sections live in Security.md). Rename the file to the
lowercase name the skill already uses and fold the operations entry into it.
@ClarrieO5
ClarrieO5 requested review from a team as code owners November 10, 2026 01:42
Copilot AI dynamic review requested due to automatic review settings November 10, 2026 01:42
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 2 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Removes or renames files

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 468d152 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ gdpr-compliant (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/gdpr-compliant
✅ gdpr-compliant (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain in the supplied evidence.

No open issues 🎉

What changed in this PR

Repairs the GDPR-compliant skill’s reference paths for case-sensitive file systems by consolidating security and operations guidance under the correctly cased lowercase reference.

Changes:

  • Updates SKILL.md to use references/security.md.
  • Consolidates security, operations, CI/CD, incident-response, and architecture guidance.
  • Updates the generated skills README with the corrected reference paths.
File Description
skills/​gdpr-compliant/​SKILL.md Points to the consolidated lowercase security reference and removes the stale operations reference.
skills/​gdpr-compliant/​references/​security.md Provides the consolidated security, operations, and architecture guidance.
docs/​README.skills.md Updates the generated resource listing with the corrected lowercase reference path.

Review effort: Lite (auto)

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 10, 2026
Copilot AI dynamic review requested due to automatic review settings November 10, 2026 05:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active issues remain, with the GDPR skill’s case-sensitive reference paths corrected and its operations guidance consolidated into the proper security reference.

No open issues 🎉

Review effort: Lite (auto)

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the case-mismatched references/Security.md path and removing the nonexistent references/operations.md reference. SKILL.md and the generated skills catalog now point to the lowercase references/security.md, and the reported skill and valid-reference checks pass. This is a useful maintenance fix for case-sensitive file systems.

@aaronpowell
aaronpowell merged commit 2df435d into github:main Nov 11, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants