Skip to content

Correct instruction scopes, API guidance, and safety boundaries 🤖🤖🤖 - #6332

Merged
aaronpowell merged 2 commits into
github:mainfrom
findscripter:findscripter/refresh-stale-instructions
Nov 11, 2026
Merged

aaronpowell merged 2 commits into
github:mainfrom
findscripter:findscripter/refresh-stale-instructions

Conversation

@findscripter

@findscripter findscripter commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Refs #6277.

Update the ten concrete priorities identified by the staleness report:

  • Follow installed Next.js/Tailwind/Rails/Terraform versions and existing project configuration rather than automatically upgrading.
  • Correct TanStack Router's errorComponent/pendingComponent examples, and narrow Playwright, CMake and Power Platform automatic scopes. Playwright location, naming and execution guidance follows the configured suite instead of imposing a tests/ directory or project name.
  • Add project-compatible Bicep parameter/module/linter guidance and AzureRM 4.x subscription selection.
  • Correct the taming instructions' priority, implementation and validation rules; replace unsupported quota/timeout claims in commenting examples.

Existing-version compatibility and project-specific configuration remain part of the guidance. The linked primary documentation is recorded in the affected files.

Validation

  • All affected frontmatters parsed successfully.
  • 36 positive/negative path-matching assertions checked the changed scope patterns.
  • Both technical-refresh groups passed npm run build; the prepared integration website build also completed.
  • git diff --check passed.

Framework applications, cloud deployments and connectors were not executed. This addresses the report's ten explicit priorities; its wider age-based review queue remains ongoing maintenance.

AI-assisted implementation and validation.

@findscripter
findscripter requested a review from a team as a code owner November 9, 2026 13:09
Copilot AI dynamic review requested due to automatic review settings November 9, 2026 13:09
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 10 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 3
ℹ️ Info 0
Severity Rule File Line Match
🟠 package-exec-command instructions/playwright-typescript.instructions.md 75 1. **Initial Run**: Use the project's Playwright test command and configured projects; `npx playwright test --project=chromium` applies when the configuration defines that project.
🟠 package-exec-command instructions/tanstack-start-shadcn-tailwind.instructions.md 213 npx shadcn@​​latest add button card input dialog
🟠 unpinned-version-indicator instructions/tanstack-start-shadcn-tailwind.instructions.md 213 npx shadcn@​​latest add button card input dialog

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added instructions PR touches instructions merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Changes 119 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for b384ce3 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk label Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test-location rule still mandates tests/ despite supporting other suite directories, potentially placing specs outside Playwright’s configured discovery paths.

1 open issue
What changed in this PR

Refreshes ten GitHub Copilot instruction resources identified in #6277 to improve version compatibility, technical accuracy, and safety.

Changes:

  • Favor installed versions and existing project configuration over automatic upgrades.
  • Correct TanStack Router options and refine automatic instruction scopes.
  • Update infrastructure guidance, implementation boundaries, and unsupported example comments.
File Description
instructions/​tanstack-start-shadcn-tailwind.instructions.md Correct route UI options and clarify version-aware configuration.
instructions/​taming-copilot.instructions.md Clarify instruction priority, implementation authorization, and validation boundaries.
instructions/​self-explanatory-code-commenting.instructions.md Replace unsupported service claims in example comments.
instructions/​ruby-on-rails.instructions.md Add Rails version context and preserve existing application choices.
instructions/​power-platform-connector.instructions.md Limit automatic scope to standard connector definition files.
instructions/​playwright-typescript.instructions.md Narrow automatic scope and reference configured test discovery.
instructions/​nextjs-tailwind.instructions.md Add version-specific Next.js and Tailwind guidance.
instructions/​generate-modern-terraform-code-for-azure.instructions.md Respect version constraints and clarify subscription selection and safe validation.
instructions/​cmake-vcpkg.instructions.md Focus scope on build configuration and preserve project conventions.
instructions/​bicep-code-best-practices.instructions.md Cover parameter files, versioned modules, and project-specific lint checks.

Review effort: Max (auto)

Copilot AI dynamic review requested due to automatic review settings November 9, 2026 13:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the instruction-resource updates.

No open issues 🎉

1 resolved since last review

Review effort: Balanced (auto)

@github-actions github-actions Bot added awaiting-automation ready-for-review Submission passed intake validation and is ready for maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review awaiting-automation labels Nov 10, 2026

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refreshing these instructions. The changes add concrete version-aware guidance—for example, the Next.js 15+ request API behavior and the AzureRM 4.x subscription requirement—while narrowing automatic scopes and preserving project-specific configurations. The PR reports successful scope checks and build validation, and the generated README check passes.

@aaronpowell
aaronpowell merged commit 2956cb5 into github:main Nov 11, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instructions PR touches instructions merge-risk:medium needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants