Skip to content

Surface and approve pending PR workflows 🤖🤖🤖 - #6314

Merged
aaronpowell merged 4 commits into
mainfrom
aaronpowell-pr-workflow-approvals
Nov 10, 2026
Merged

aaronpowell merged 4 commits into
mainfrom
aaronpowell-pr-workflow-approvals

Conversation

@aaronpowell

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Bot-created and other same-repository PRs can have workflows waiting for approval, but the Open PR Board previously only discovered approvals for public forks.

  • Surface eligible waiting workflows on cards and in Checks, with an individual action to approve execution via gh api.
  • Make individual and bulk Approve + auto-merge also approve waiting workflows at the reviewed commit before requesting auto-merge. Confirmation discloses that contributor code will run; required checks remain in force.
  • Recheck the PR head, run attempt and jobs before approving. If a workflow approval fails, report the partial result and do not request auto-merge. Runs with existing jobs are not treated as execution-approval candidates, avoiding confusion with submission gates.

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

  • npm start - passed; no generated README changes. The external catalog reported three existing non-SPDX license warnings.
  • npm run plugin:validate - passed with the same license warnings.
  • node --experimental-vm-modules --test --test-reporter=dot eng\open-pr-board-workflow-approval.test.mjs eng\open-pr-board.test.mjs eng\board-preview.test.mjs eng\board-bulk-actions.test.mjs eng\open-pr-board-prompt-security.test.mjs eng\board-periodic-refresh.test.mjs - passed.
  • bash eng/fix-line-endings.sh - passed.
  • Read-only discovery found the waiting workflows on [bot] Update Learning Hub for CLI settings dashboard and /code #6284. The extension was reloaded, but no manual canvas interaction or live workflow approval POST was performed.
  • GitHub's approval endpoint has no atomic head or attempt precondition; the board rechecks immediately before each write.
  • Paid-services submission guidance and adding a new resource do not apply.

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aaronpowell
aaronpowell requested a review from a team as a code owner November 9, 2026 05:53
Copilot AI dynamic review requested due to automatic review settings November 9, 2026 05:53
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • .github/extensions/open-pr-board/README.md is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/extensions/open-pr-board/lib/decisions.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/extensions/open-pr-board/lib/github.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/extensions/open-pr-board/lib/review-prompt.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/extensions/open-pr-board/public/app.js is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/extensions/open-pr-board/public/index.html is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/board-bulk-actions.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/board-preview.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/open-pr-board-prompt-security.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/open-pr-board-workflow-approval.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/open-pr-board.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ✅ Passed Passed · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for faf72ac · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Automatic approval can authorize another PR’s merge-context workflow when an empty pull_requests list bypasses PR-number and base-branch checks.

2 open issues
What changed in this PR

Extends the Open PR Board’s workflow approval support to public same-repository PRs, including bot-created PRs, alongside public forks.

Changes:

  • Surfaces eligible waiting workflows on cards and in Checks, excluding runs with existing jobs.
  • Adds workflow authorization to individual and bulk Approve + auto-merge, with freshness checks and partial-result recording.
  • Updates execution warnings, documentation, and regression coverage.
File Description
eng/​open-pr-board-workflow-approval.test.mjs Covers same-repository discovery, combined approvals, stale state, and partial failures.
eng/​board-preview.test.mjs Checks execution disclosures and pending-workflow rendering.
eng/​board-bulk-actions.test.mjs Verifies bulk approval safety disclosures.
.github/​extensions/​open-pr-board/​README.md Documents eligibility, combined actions, and failure handling.
.github/​extensions/​open-pr-board/​public/​index.html Explains workflow authorization in the action footer.
.github/​extensions/​open-pr-board/​public/​app.js Updates confirmations and the Checks interface.
.github/​extensions/​open-pr-board/​lib/​review-prompt.mjs Broadens review guidance beyond fork workflows.
.github/​extensions/​open-pr-board/​lib/​github.mjs Adds jobs validation and workflow authorization during combined approval.
.github/​extensions/​open-pr-board/​lib/​decisions.mjs Records workflow approvals separately from PR decisions.

Review effort: Max (auto)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI dynamic review requested due to automatic review settings November 9, 2026 22:51
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 9, 2026
@aaronpowell

Copy link
Copy Markdown
Contributor Author

Regarding the contributor reputation check: thanks, noted. This is an automated maintainer-review advisory rather than an implementation request, so no code changes were needed for this comment.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

Regarding the submission-gate status update: thanks, noted. It reports the maintainer approval requirement and advisory checks for the then-current commit. This is status information rather than code feedback, so no implementation change was needed for this comment.

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Individual-confirmation approvals can authorize another PR’s workflow, while prompt escaping corrupts identifiers and evidence references.

2 open issues
2 resolved since last review

Review effort: Max (auto)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI dynamic review requested due to automatic review settings November 9, 2026 23:22
@aaronpowell

Copy link
Copy Markdown
Contributor Author

Noted. This contributor check is a maintainer-review advisory, not a code-change request. The latest fixes are now pushed as c1ba667; maintainers should use the current-head check result when assessing the PR.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

Noted. This gate status describes the prior commit and records the submission-gate and maintainer-approval requirements. The latest review fixes are now pushed as c1ba667; current-head checks should be used for the up-to-date status.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement already addresses the prior submission-gate status. The latest code-fix commit is now pushed, so the current-head submission-gate result is the relevant status.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement already addresses the contributor reputation advisory referenced here. The newer bot status is informational as well; maintainers should review the latest run for the current PR head.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The allow-lists omit comment and NONE, incorrectly serializing feedback-only actions and known absent review decisions as UNKNOWN and losing meaningful state in the review prompt.

2 open issues
2 resolved since last review

Review effort: Max (auto)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI dynamic review requested due to automatic review settings November 10, 2026 00:23
@aaronpowell

Copy link
Copy Markdown
Contributor Author

Noted. This is a maintainer-review advisory rather than an implementation request. The latest fixes are pushed as faf72ac; maintainers should use the current-head result when assessing the PR.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This duplicate acknowledgement already noted the contributor advisory. It is informational rather than a code request; maintainers should review the result for the current head faf72ac.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement addressed the contributor reputation advisory then present. The latest prompt fixes are now pushed; maintainers can assess the current-head checks.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement covered the submission-gate status for the prior commit. The latest prompt fixes are pushed as faf72ac; the current-head gate result is the applicable status.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement addressed the contributor advisory for the preceding run. The latest prompt fixes are pushed as faf72ac; please refer to checks for the current PR head.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This duplicate acknowledgement already noted the earlier submission-gate status. No code change was requested by that status; the current-head result should be used after faf72ac.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

This earlier acknowledgement addressed the submission-gate status at that time. The prompt fixes are now pushed, so the current-head gate result is the relevant status.

@aaronpowell

Copy link
Copy Markdown
Contributor Author

Noted. The status records the submission-gate and maintainer-approval requirements for the reported run. Prompt fixes are now pushed as faf72ac; please use the current-head checks for updated status.

@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 10, 2026
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because critical findings omitted from the published review identify a stale-head approval race and a failing regression test.

No open issues 🎉

2 resolved since last review

Review effort: Max (auto)

@aaronpowell
aaronpowell merged commit 55bddd4 into main Nov 10, 2026
31 of 33 checks passed
@aaronpowell
aaronpowell deleted the aaronpowell-pr-workflow-approvals branch November 10, 2026 04:05

This branch was successfully deployed

1 active deployment
github-pages — faf72ac4 Deployed Nov 10, 2026 by aaronpowell via deploy #1371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:high needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants