fix: support runner subnets in the same availability zone - #5304
Open
Quindrix wants to merge 1 commit into
Open
Conversation
Group subnets into AZ-safe fleet requests and distribute capacity across them. Carry retryable failures forward to alternative subnets and add the required DescribeSubnets permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows runner subnets to exist in the same AZ. It groups the configured subnets into safe combinations and distributes runner capacity across separate fleet requests. If a request encounters a retryable capacity failure, the remaining capacity is carried forward to the next available subnet combination.
It also adds the required
ec2:DescribeSubnetspermissions and updates the documentation to remove the previous requirement that every subnet must be in a different AZ. Dedicated-host and explicit subnet override behaviour remains unchanged.Test Plan
Related Issues
Fixes #5297, and follows on from #2904