Repository navigation
Fix: notch never showed up on extended multi-monitor setups - #113
Merged
Merged
Conversation
…ended multi-monitor setups The notch's own PanelWindow had no screen: property and no Variants over Quickshell.screens, unlike ruixen.bar's own per-screen windows -- so on an extended multi-monitor desktop it only ever mapped to one output, leaving every other monitor without a notch at all (mirrored output happened to look fine since it's the same framebuffer duplicated, masking the bug). Split the window's visible content out into NotchWindow.qml, instantiated once per screen via Variants, with a notchRoot back- reference to Overlay.qml's own root -- the same pattern ruixen.bar's own Phase 6 refactor already established for FrameWindow/BarPanel. Singleton services (NotificationService/KanbanService/AppLibrary/ CavaFeed) and the "ruixen.notch" IpcHandler stay on root, genuinely once each -- duplicating those per screen would register the IPC target N times and give every monitor independent board/notification state. The dashboard/launcher open/closed/tab state moved to root too (shared), gated per-window by a new activeScreenName so only the screen that was actually clicked renders the expanded view and grabs exclusive keyboard focus -- otherwise every monitor would try to open the full interactive dashboard and fight over Wayland focus at once. Hover-reveal state went the other direction, from shared to per-window local, so hovering the pill on one monitor doesn't fade it in on every other one. Updated the dependent test files whose checks grepped the window content's old single-file location.
Both test files retargeted their only overlay_qml check to the new notch_window_qml file in the previous commit, leaving the original variable declared but never read -- shellcheck's default unused- variable check caught it in CI even though nothing here exercises it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PanelWindowhad noscreen:property and noVariantsoverQuickshell.screens, unlikeruixen.bar's own windows — on an extended multi-monitor desktop it only ever mapped to one output, leaving every other monitor without a notch. Mirrored output looked fine by coincidence (same framebuffer duplicated), which masked the bug there.NotchWindow.qml, instantiated once per screen viaVariants, following thebarRoot-forwarding pattern already established inruixen.bar's own Phase 6 refactor.ruixen.notchIPC target stay on root, genuinely once each.activeScreenName, so only the screen actually clicked renders the expanded view and grabs exclusive keyboard focus — not every monitor at once.Test plan
tests/run-all.shpasses in full (13 test files updated for the new file layout)qmllintclean on both files (no new warning classes vs. the pre-change baseline)🤖 Generated with Claude Code