Skip to content

fix(ci): publish version from tag; drop --skip-duplicate and version trap #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giammin merged 2 commits into from
Jul 23, 2026
Merged

fix(ci): publish version from tag; drop --skip-duplicate and version trap #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7646b
fix(ci): derive nuget package version from the pushed tag
giammin Jul 23, 2026
3c38758
fix(ci): drop --skip-duplicate and remove hardcoded version trap
giammin Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/nuget-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ jobs:
- name: Restore dependencies
run: dotnet restore
- name: Build
run: dotnet build --no-restore -c Release
# Derive the package version from the pushed tag (e.g. v1.1.4 -> 1.1.4).
# -p:Version is a global MSBuild property; PackageVersion, FileVersion and
# AssemblyVersion all derive from it.
run: dotnet build --no-restore -c Release -p:Version=${GITHUB_REF_NAME#v}
- name: Test
run: dotnet test --no-build --verbosity normal -c Release
- name: NuGet login (OIDC → temp API key) # Get a short-lived NuGet API key
Expand All @@ -27,4 +30,4 @@ jobs:
with:
user: ${{ secrets.NUGET_USER }}
- name: Push
run: dotnet nuget push "./build/*.symbols.nupkg" --skip-duplicate --api-key ${{steps.login.outputs.NUGET_API_KEY}} --source https://api.nuget.org/v3/index.json
run: dotnet nuget push "./build/*.symbols.nupkg" --api-key ${{steps.login.outputs.NUGET_API_KEY}} --source https://api.nuget.org/v3/index.json
12 changes: 0 additions & 12 deletions src/Directory.Build.targets
View file
Open in desktop

This file was deleted.

Loading