Skip to content

fix(common): rename changeColumnsArrangement to applyColumnLayout - #2779

Merged
ghiscoding merged 1 commit into
masterfrom
chore/deprecate-change-column-arrangement
Sep 1, 2026
Merged

fix(common): rename changeColumnsArrangement to applyColumnLayout#2779
ghiscoding merged 1 commit into
masterfrom
chore/deprecate-change-column-arrangement

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

Fix the column layout API naming by introducing applyColumnLayout() as the preferred method name.

Why

changeColumnsArrangement(), in GridStateService, is awkward and does not clearly describe that the method applies column order, visibility, and width state. The new name applyColumnLayout() better represent the usage.

Changes

  • Rename the preferred API to applyColumnLayout() in GridStateService.
  • Retain changeColumnsArrangement() as a deprecated compatibility alias.
  • Plan to remove the deprecated alias in v11.
  • Update Angular, Aurelia, React, Vanilla Bundle, and Vanilla demo call sites.
  • Update and extend focused unit tests.

Validation

  • Grid state tests: 72 passed.
  • Angular component tests: 118 passed.
  • Vanilla Bundle tests: 116 passed.
  • Prettier and git diff --check passed.
  • React/Aurelia standalone typechecks require regenerated packages/common/dist declarations.

Comments

This is an API naming fix; existing consumers using changeColumnsArrangement() remain supported during the deprecation period.

AI / LLM assistance

  • AI / LLM assistance used:
    • No
    • Yes
  • If Yes:
    • which tool/model: Codex GPT-5.6 Luna
    • how was it used: Reviewed the API, implemented the compatible rename, updated call sites and tests, and validated the changes.

Checklist

  • The changes are limited to only one scope.
  • Tests were added or updated where appropriate.
  • Documentation was updated where appropriate.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (2414a21) to head (d042f84).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2779   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         199      199           
  Lines       25776    25776           
  Branches     9132     9132           
=======================================
  Hits        25776    25776           
Flag Coverage Δ
angular 100.0% <100.0%> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2779

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2779

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2779

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2779

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2779

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2779

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2779

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2779

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2779

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2779

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2779

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2779

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2779

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2779

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2779

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2779

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2779

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2779

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2779

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2779

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2779

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2779

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2779

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2779

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2779

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2779

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2779

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2779

commit: d042f84

@ghiscoding
ghiscoding merged commit 33bfbb1 into master Sep 1, 2026
18 checks passed
@ghiscoding
ghiscoding deleted the chore/deprecate-change-column-arrangement branch September 1, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant