Skip to content

fix(github): Link details to the exact check run - #457

Merged
dcramer merged 4 commits into
mainfrom
fix/exact-check-details-url
Jul 28, 2026
Merged

fix(github): Link details to the exact check run#457
dcramer merged 4 commits into
mainfrom
fix/exact-check-details-url

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Correct the check details destination introduced in #430. Each check now points to its own GitHub check-run page instead of the commit-wide checks page, which can select an unrelated check.

Because GitHub assigns the check-run ID during creation, Warden follows creation with a metadata update using the returned html_url.

Verified with the focused GitHub checks test suite and monorepo typecheck.

--

View Junior Session

Co-Authored-By: immutable dcramer <david@sentry.io>
@dcramer
dcramer marked this pull request as ready for review July 28, 2026 19:56

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 76f183d. Configure here.

Comment thread packages/warden/src/output/github-checks.ts Outdated
@dcramer
dcramer merged commit dc26ae6 into main Jul 28, 2026
21 checks passed
@dcramer
dcramer deleted the fix/exact-check-details-url branch July 28, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant