Skip to content

Avoid naming overflow in k8s - #372

Merged
fpacifici merged 1 commit into
mainfrom
fpacifici/longer_labels
Aug 31, 2026
Merged

Avoid naming overflow in k8s#372
fpacifici merged 1 commit into
mainfrom
fpacifici/longer_labels

Conversation

@fpacifici

Copy link
Copy Markdown
Collaborator

Cap the size of the pipeline-pp label in the pipeline step macro.
pipeline-app is the whole python package so it can be logner than
63 characters, which is the maximum allowed by k8s.

I would like to remove this label entirely. I doubt it would actually
be useful, but selector labels require the deployment to be recreated
to make changes, so we only cap it

@fpacifici
fpacifici requested a review from a team as a code owner August 31, 2026 22:35

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ebd0d94. Configure here.

Comment thread sentry_streams_k8s/sentry_streams_k8s/consumer_builder.py Outdated
Comment thread sentry_streams_k8s/sentry_streams_k8s/consumer_builder.py Outdated
@fpacifici
fpacifici force-pushed the fpacifici/longer_labels branch from ebd0d94 to 2460d8d Compare August 31, 2026 22:47
@fpacifici
fpacifici merged commit 1f70fe8 into main Aug 31, 2026
27 checks passed
@fpacifici
fpacifici deleted the fpacifici/longer_labels branch August 31, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants