fix(admin): Allow listing migrations without every storage set configured - #8412
Open
phacops wants to merge 1 commit into
Open
fix(admin): Allow listing migrations without every storage set configured#8412phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
Listing migrations imports historical modules that name storage sets absent from this process's cluster config, which 500'd /migrations/groups. Keep identifiers constructible; get_cluster() still fails if unmapped. Fixes SNUBA-CKE
phacops
marked this pull request as ready for review
August 28, 2026 19:00
Contributor
|
If we have a small list of legacy storage sets, is that a reasonable approach? |
Member
yeah i was about to suggest having |
Contributor
Author
Why do we care about controlling all this? If the storage set is not configured, we don't see the migration groups in the list and that's it. We don't need to have a controlled number of migration sets not in the list? |
pbhandari
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /migrations/groupsimported every historical migration to build the list. Those modules referenceStorageSetKeynames that only existed if this process's cluster config had registered them, so a missinggeneric_metrics_distributionsmapping 500'd the whole page.StorageSetKey.FOOis now always constructible.get_cluster()still raises if that set isn't mapped, so you cannot run DDL against a cluster that isn't there.Fixes SNUBA-CKE