fix(sentry-apps): Prevent MissingSchema with empty webhook_url - #121494
Open
sentry[bot] wants to merge 1 commit into
Open
fix(sentry-apps): Prevent MissingSchema with empty webhook_url#121494sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause was that the
send_and_save_webhook_requestfunction insrc/sentry/utils/sentry_apps/webhooks.pywould assignurl = ''ifsentry_app.webhook_urlwas an empty string. The subsequentassert url is not Nonewould pass, leading to_send_webhook_request('')and theMissingSchemaexception.This issue was previously fixed in PR #119122 by adding
if not url: return Response()after the URL assignment. However, this guard was inadvertently removed in a later PR (#120280), causing the regression.This fix re-introduces the
if not url: return Response()guard immediately after the URL assignment (line 258) and removes the now-redundantassert url is not None(line 269). This ensures that if a SentryApp does not have a webhook URL configured (i.e., it's an empty string or None), the webhook sending is silently skipped, preventing theMissingSchemaerror.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5HAE
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.