fix(conversations): Open conversation in new tab on cmd/ctrl+click - #121487
Merged
ArthurKnaus merged 2 commits intoAug 7, 2026
Merged
Conversation
Conversation rows navigated via a JS onClick handler, so Cmd/Ctrl+click had no URL to act on and just navigated in place instead of opening a new tab. Read the click event's modifier keys and use window.open instead of navigate() when Cmd/Ctrl (new tab) or Shift (new window) is held, matching native link behavior. Refs TET-2803 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ArthurKnaus
marked this pull request as ready for review
August 6, 2026 21:36
constantinius
approved these changes
Aug 6, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…open-in-a-new-tab
github-actions
Bot
added
the
Scope: Frontend
ArthurKnaus
deleted the
arthurknaus/tet-2803-conversations-do-not-open-in-a-new-tab
branch
August 7, 2026 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversation rows navigate via a JS
onClickhandler rather than a real link, so Cmd/Ctrl+click had no URL to act on and just navigated in place instead of opening a new tab.Reads the click event's modifier keys and uses
window.openinstead ofnavigate()when Cmd/Ctrl (new tab) or Shift (new window) is held, matching native link behavior.Refs TET-2803