ref(seer): Restore Seer automation in post-process and widen the killswitch - #121486
Open
skonves wants to merge 2 commits into
Open
ref(seer): Restore Seer automation in post-process and widen the killswitch#121486skonves wants to merge 2 commits into
skonves wants to merge 2 commits into
Conversation
…)" This reverts commit 5bca0c8. Put kick_off_seer_automation back in GROUP_CATEGORY_POST_PROCESS_PIPELINE and in GENERIC_POST_PROCESS_PIPELINE. Remove the five xfail marks that the original commit added to the post-process tests.
The seer.post-process-issue-summary-killswitch.enabled check was inside the is_seer_seat_based_tier_enabled block. Only seat-based organizations obeyed the killswitch. The default tier still started Seer automation. The check is now the first statement in kick_off_seer_automation. The killswitch stops all Seer work in post-process for both tiers.
Member
|
Sorry missed the ping for this. Yea seems like we can probably remove this now that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does two things. It reverts #121426. It then makes the issue summary killswitch apply to every plan tier.
Revert of #121426
#121426 removed
kick_off_seer_automationfromGROUP_CATEGORY_POST_PROCESS_PIPELINEand fromGENERIC_POST_PROCESS_PIPELINE. It also marked five tests intests/sentry/tasks/test_post_process.pyasxfail.The first commit reverts that change.
kick_off_seer_automationruns in both pipelines again. The five tests run and pass again.Killswitch move
The
seer.post-process-issue-summary-killswitch.enabledcheck sat inside theis_seer_seat_based_tier_enabledblock. Only seat-based organizations obeyed the killswitch. The default tier reachedgenerate_summary_and_run_automationeven when an operator turned the killswitch on.The second commit moves the check to the first statement of
kick_off_seer_automation. The killswitch now stops all Seer work in post-process for both tiers.Behavior change to note
This widens the reach of the option.
generate_summary_and_run_automationon the default tier now respects the killswitch. Reviewers should confirm that this matches the intent of the option.Tests
pytest tests/sentry/tasks/test_post_process.py -k seerpasses. 25 tests pass.