feat(integration): add tooltip to pending deletion - #121473
Open
sentaur-athena wants to merge 2 commits into
Open
feat(integration): add tooltip to pending deletion#121473sentaur-athena wants to merge 2 commits into
sentaur-athena wants to merge 2 commits into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+347
to
+356
| <Button | ||
| size="sm" | ||
| disabled | ||
| tooltipProps={{ | ||
| title: t('Deletion is in progress. This may take a few minutes.'), | ||
| isHoverable: true, | ||
| position: 'top', | ||
| }} | ||
| data-test-id="pending-deletion-button" | ||
| > |
Contributor
There was a problem hiding this comment.
Bug: The tooltip on the disabled 'Pending Deletion' button will never be displayed because disabled buttons do not fire the pointer events required to trigger the tooltip.
Severity: MEDIUM
Suggested Fix
To allow the tooltip to be triggered, wrap the disabled Button component in a <span> or <div>. Apply the tooltipProps to this new wrapper element, which can receive pointer events even when the button inside it is disabled. This will enable the tooltip to appear correctly on hover.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
static/app/views/settings/organizationIntegrations/sentryAppDetailedView.tsx#L347-L356
Potential issue: A `Tooltip` is being applied to a `Button` component that is
conditionally `disabled`. According to standard browser behavior, HTML elements with the
`disabled` attribute do not fire pointer events such as `onPointerEnter` or
`onPointerLeave`. The `Tooltip` component's visibility is triggered by these events via
the `useHoverOverlay` hook. Since the disabled button blocks these events, the tooltip
intended to inform the user that "Deletion is in progress" will never appear. This makes
the feature added in the pull request non-functional, as there is no CSS mitigation like
`pointer-events: none` to work around this browser behavior.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
It does though 🤔 see the screen shot
Christinarlong
approved these changes
Aug 6, 2026
sentaur-athena
enabled auto-merge (squash)
August 6, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ISWF-1674