Skip to content

impr(jira): Add new format for explicit deletes by sending diff from frontend - #121472

Open
Christinarlong wants to merge 6 commits into
fix/jira-explicit-mapping-removalsfrom
Christinarlong/jira-mapping-removals-ui
Open

impr(jira): Add new format for explicit deletes by sending diff from frontend#121472
Christinarlong wants to merge 6 commits into
fix/jira-explicit-mapping-removalsfrom
Christinarlong/jira-mapping-removals-ui

Conversation

@Christinarlong

@Christinarlong Christinarlong commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Basically the flow is if we see the provider is JIRA, the feature flag ('jira-explicit-mapping-removals') is on, and the field is sync_status_forward then change the frontend mutation/payload when updating the config to be

"sync_status_forward" : {
    "123456": {"on_resolve": "123" , "on_unresolve": "456"},
    "67890":  null
     ....
}

As opposed the current of

"sync_status_forward": {
    "123456": {"on_resolve": "123" , "on_unresolve": "456"},
    "67890": {"on_resolve": "1" , "on_unresolve": "789"} 
     ....
}

@Christinarlong
Christinarlong marked this pull request as ready for review August 6, 2026 19:58
@Christinarlong
Christinarlong requested a review from a team as a code owner August 6, 2026 19:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit feb17a1. Configure here.

@Christinarlong
Christinarlong requested a review from a team August 6, 2026 20:21

@ceorourke ceorourke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmy backend eyes 😵‍💫

);
});

it('appends a tombstone for a removed Jira mapping when enabled', async () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague memory of Gabe pushing back on the naming of this "tombstone", maybe update this to whatever he suggested instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop yes good catch 🙇‍♀️

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants