Skip to content

feat(workflow-engine): Hook into organization creation signals - #121471

Merged
leeandher merged 6 commits into
masterfrom
leanderrodrigues/iswf-3209-hook-into-organization-creation-signals
Aug 7, 2026
Merged

feat(workflow-engine): Hook into organization creation signals#121471
leeandher merged 6 commits into
masterfrom
leanderrodrigues/iswf-3209-hook-into-organization-creation-signals

Conversation

@leeandher

Copy link
Copy Markdown
Member

Adds a new BetterSignal, and triggers it from the cell provisioning rpc for creating organizations. There is precedent for this with the terms_accepted signal, so it should be okay.

We're also adding the receiver, but it's gated by an option to be a noop on merge, we can control its rollout when we're ready.


Stack created with GitHub Stacks CLIGive Feedback 💬

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

ISWF-3209

@leeandher
leeandher force-pushed the leanderrodrigues/iswf-3209-hook-into-organization-creation-signals branch from d4a6c58 to 9932a77 Compare August 6, 2026 20:53

@saponifi3d saponifi3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayyyy!!!! Looks great!

Comment thread src/sentry/workflow_engine/receivers/organization_detectors.py Outdated
@leeandher
leeandher force-pushed the leanderrodrigues/iswf-3209-hook-into-organization-creation-signals branch from 9932a77 to 8c94d78 Compare August 7, 2026 15:57
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 7, 2026
@leeandher
leeandher marked this pull request as ready for review August 7, 2026 16:02
@leeandher
leeandher requested review from a team as code owners August 7, 2026 16:02
Comment thread src/sentry/workflow_engine/defaults/workflows.py
@leeandher
leeandher force-pushed the leanderrodrigues/iswf-3209-hook-into-organization-creation-signals branch from d63d24f to 7384516 Compare August 7, 2026 18:10
@leeandher
leeandher requested review from a team as code owners August 7, 2026 18:10
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 7, 2026
@github-actions

This comment was marked as outdated.

@leeandher
leeandher removed request for a team August 7, 2026 18:12
@leeandher

Copy link
Copy Markdown
Member Author

dont git push -f while using gh stack i guess, broke something

@leeandher
leeandher marked this pull request as ready for review August 7, 2026 18:13
Base automatically changed from leanderrodrigues/iswf-3107-allow-the-frontend-builder-to-create-a-workflow-for-all to master August 7, 2026 19:37
@leeandher
leeandher force-pushed the leanderrodrigues/iswf-3209-hook-into-organization-creation-signals branch from 0f1b9a6 to 1e061b5 Compare August 7, 2026 19:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e061b5. Configure here.

workflows: list[Workflow],
) -> Sequence[DetectorWorkflow]:
connections = [DetectorWorkflow(workflow=workflow, detector=detector) for workflow in workflows]
return DetectorWorkflow.objects.bulk_create(connections, ignore_conflicts=True)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused detector workflow helper

Low Severity

connect_workflows_to_detector is added but never called. Connection is already done inside create_and_connect_pull_request_workflow via DetectorWorkflow.objects.create, so this helper is dead code that mirrors the unused parallel to connect_workflows_to_issue_stream.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1e061b5. Configure here.

@leeandher
leeandher merged commit 0bdec79 into master Aug 7, 2026
83 of 86 checks passed
@leeandher
leeandher deleted the leanderrodrigues/iswf-3209-hook-into-organization-creation-signals branch August 7, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants