fix(grouping): Bound lookaheads in parameterization regexes - #121470
Merged
Conversation
The hostname and multi_part_random_id patterns each use an unbounded lookahead to check for a letter/digit ahead. Bound both to the max segment/first-part length they gate, which the pattern already enforces, so match behavior is unchanged. Refs VULN-2665 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
shashjar
approved these changes
Aug 6, 2026
The bounded lookaheads added in 34eea24 could reject valid multi-part random IDs whose qualifying letter or digit falls outside the chosen window, leaving them unparameterized. Revert to the original lookaheads to restore correct grouping behavior. The hostname fix in this branch is unaffected and unrelated to this pattern. Refs VULN-2665 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.