fix(explore): Validate metric group by selections - #121466
Open
nsdeschenes wants to merge 5 commits into
Open
Conversation
Use validation results to classify selected fields, hide unresolved URL values, and remove invalid group bys only after current validation settles. Refs EXP-1024
Exercise validated field types, pending selection hiding, stale placeholder protection, and invalid group by cleanup. Refs EXP-1024
github-actions
Bot
added
the
Scope: Frontend
Keep metric validation active after invalid group bys are removed so placeholder data is replaced and the selector becomes enabled again. Refs EXP-1024
Centralize invalid group by cleanup, visibility, and validated tag merging across spans and metrics while preserving their mode-specific behavior. Refs EXP-1024
Provide neutral validation responses in metric tab and panel fixtures now that group by validation remains active after cleanup. Refs EXP-1024
nsdeschenes
marked this pull request as ready for review
August 7, 2026 13:17
narsaynorath
approved these changes
Aug 7, 2026
narsaynorath
left a comment
narsaynorath
left a comment
Member
There was a problem hiding this comment.
Looks good to me, tested with some non-valid groupings and it worked as expected 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metric group-by selectors now validate URL and user selections against the events validation endpoint when selected fields are absent from attribute results. Valid fields render with their validated types, unresolved or invalid values stay hidden, and invalid selections are removed only after validation settles while preserving blank values and aggregate mode.
The cleanup associates each validation response with its group-by snapshot so placeholder data from a previous query cannot strip a newer selection. This mirrors the spans group-by behavior and covers field classification, loading state, stale validation data, and query-parameter cleanup.
Closes EXP-1024