Skip to content

Remove isLegacyAlert from the anomaly thresholds hook #121464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ceorourke merged 1 commit into from
Aug 7, 2026
+0 −47
Merged

Remove isLegacyAlert from the anomaly thresholds hook #121464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions static/app/views/detectors/hooks/useMetricDetectorAnomalyThresholds.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,48 +110,4 @@ describe('useMetricDetectorAnomalyThresholds', () => {

expect(anomalyDataRequest).not.toHaveBeenCalled();
});

it('includes legacy_alert query param when isLegacyAlert is true', async () => {
const organization = OrganizationFixture();

const mockData = [
{
external_alert_id: 24,
timestamp: 1609459200,
value: 100,
yhat_lower: 80,
yhat_upper: 120,
},
];

const anomalyDataRequest = MockApiClient.addMockResponse({
url: `/organizations/${organization.slug}/detectors/123/anomaly-data/`,
body: {data: mockData},
match: [MockApiClient.matchQuery({legacy_alert: 'true'})],
});

const series = [
{
seriesName: 'count()',
data: [{name: 1609459200000, value: 100}],
},
];

renderHookWithProviders(
() =>
useMetricDetectorAnomalyThresholds({
detectorId: '123',
detectionType: 'dynamic',
startTimestamp: 1609459200,
endTimestamp: 1609545600,
series,
isLegacyAlert: true,
}),
{organization}
);

await waitFor(() => {
expect(anomalyDataRequest).toHaveBeenCalled();
});
});
});
3 changes: 0 additions & 3 deletions static/app/views/detectors/hooks/useMetricDetectorAnomalyThresholds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ interface UseMetricDetectorAnomalyThresholdsProps {
detectorId: string;
detectionType?: string;
endTimestamp?: number;
isLegacyAlert?: boolean; // for Alerts, remove this once every AlertRule has a migrated Detector
series?: Series[];
startTimestamp?: number;
}
Expand All @@ -49,7 +48,6 @@ export function useMetricDetectorAnomalyThresholds({
startTimestamp,
endTimestamp,
series = [],
isLegacyAlert = false,
}: UseMetricDetectorAnomalyThresholdsProps): UseMetricDetectorAnomalyThresholdsResult {
const organization = useOrganization();
const theme = useTheme();
Expand All @@ -72,7 +70,6 @@ export function useMetricDetectorAnomalyThresholds({
query: {
start: startTimestamp,
end: endTimestamp,
...(isLegacyAlert && {legacy_alert: 'true'}),
},
},
],
Expand Down
Loading