feat(aci): Insert every_event condition when editing alerts with no "when" conditions - #121463
Open
RudraPatel2003 wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
the
Scope: Frontend
RudraPatel2003
changed the title
RudraPatel2003
marked this pull request as ready for review
August 6, 2026 20:18
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9dee5ed. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting no triggers is equivalent to selecting the every_event trigger but the UX of the form does not clearly reflect that. The simplest solution is a UI only element that shows what happens if you have no triggers selected.When someone opens the edit form and has no triggers, it is unclear what that means. This now inserts the every_event condition if they open the form so it is clear what they are doing. You also now can't delete a row if you only have one. This will slowly nudge people towards having their triggers explicitly laid out. No backend changes so scripts or people that never edit their alert have empty condition array work just fine