fix(github-integration): Distinguish 410 for deleted issues from disabled issues#116142
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(github-integration): Distinguish 410 for deleted issues from disabled issues#116142sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub uses the 410 status code for two distinct scenarios: when the issues feature is disabled for a repository, and when a specific issue has been deleted. The previous implementation did not differentiate between these, leading to misleading error messages and unnecessary noise in Sentry.
This fix modifies the
raise_errormethod to inspect the JSON error message returned by GitHub for 410 responses. If the message indicates that the specific issue was "deleted", it now raises anIntegrationResourceNotFoundError. For all other 410 responses, the originalIntegrationConfigurationErroris raised, correctly indicating when the issues feature is truly disabled.This change provides more accurate error reporting, helping users and Sentry maintainers to better understand the root cause of integration failures.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5P3Z