ref(seer): Remove seer-slack-workflows and seer-slack-explorer flags#116140
Open
leeandher wants to merge 2 commits into
Open
ref(seer): Remove seer-slack-workflows and seer-slack-explorer flags#116140leeandher wants to merge 2 commits into
leeandher wants to merge 2 commits into
Conversation
Release both feature flags to everyone by removing their registrations and all gating logic. SlackAutofixEntrypoint.has_access now always returns True, and SlackAgentEntrypoint.has_access no longer checks the removed seer-slack-explorer flag — it only checks seer agent subscription access. The CONTROL silo path in event.py no longer needs a feature flag gate since the flag is gone; it now unconditionally allows orgs through, deferring the full access check to CELL silo as before. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
leeandher
commented
May 25, 2026
| def has_feature_flag(organization: Organization | RpcOrganization) -> bool: | ||
| return features.has("organizations:seer-slack-explorer", organization) | ||
|
|
||
| # TODO(Leander): This should probably move to the SeerAgentOperator class, any future entrypoint will be checking the same flag, not just Slack. |
Member
Author
There was a problem hiding this comment.
Gonna follow up with this rather than do it here to keep the change easier to review
Re-add seer-slack-workflows and seer-slack-explorer to the feature manager so existing FlagPole overrides don't emit warnings. The flags are no longer checked in code but will be removed from the manager after the overrides are cleaned up. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes the
seer-slack-workflowsandseer-slack-explorerfeature flags, releasing both to everyone. all gating logic, flag registrations, and related tests have been cleaned up.