Skip to content

ref(seer): Remove seer-slack-workflows and seer-slack-explorer flags#116140

Open
leeandher wants to merge 2 commits into
masterfrom
leanderrodrigues/iswf-2742-clean-up-flags
Open

ref(seer): Remove seer-slack-workflows and seer-slack-explorer flags#116140
leeandher wants to merge 2 commits into
masterfrom
leanderrodrigues/iswf-2742-clean-up-flags

Conversation

@leeandher
Copy link
Copy Markdown
Member

removes the seer-slack-workflows and seer-slack-explorer feature flags, releasing both to everyone. all gating logic, flag registrations, and related tests have been cleaned up.

Release both feature flags to everyone by removing their registrations
and all gating logic. SlackAutofixEntrypoint.has_access now always returns
True, and SlackAgentEntrypoint.has_access no longer checks the removed
seer-slack-explorer flag — it only checks seer agent subscription access.

The CONTROL silo path in event.py no longer needs a feature flag gate
since the flag is gone; it now unconditionally allows orgs through,
deferring the full access check to CELL silo as before.

Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 25, 2026

ISWF-2742

@leeandher leeandher requested a review from alexsohn1126 May 25, 2026 18:25
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 25, 2026
@leeandher leeandher marked this pull request as ready for review May 25, 2026 18:25
@leeandher leeandher requested review from a team as code owners May 25, 2026 18:25
def has_feature_flag(organization: Organization | RpcOrganization) -> bool:
return features.has("organizations:seer-slack-explorer", organization)

# TODO(Leander): This should probably move to the SeerAgentOperator class, any future entrypoint will be checking the same flag, not just Slack.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna follow up with this rather than do it here to keep the change easier to review

Re-add seer-slack-workflows and seer-slack-explorer to the feature
manager so existing FlagPole overrides don't emit warnings. The flags
are no longer checked in code but will be removed from the manager
after the overrides are cleaned up.

Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant