Repository navigation
feat(bedrock): Set token attributes for streamed responses - #8235
Merged
Merged
Conversation
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
from
November 10, 2026 11:34
74d8ae4 to
672b917
Compare
alexander-alderman-webb
marked this pull request as ready for review
November 10, 2026 11:36
alexander-alderman-webb
marked this pull request as draft
November 10, 2026 11:45
Contributor
Coverage Results 📊✅ 137444 passed | ⏭️ 7671 skipped | Total: 145115 | Pass Rate: 94.71% | Execution Time: 435m 15s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 80.19% (85 of 106 changed executable lines covered; target 80%). Changed files with executable lines (4)
Coverage diff@@ Coverage Diff @@
## master #8235 +/-##
==========================================
- Coverage 90.31% 90.24% -0.07%
==========================================
Files 203 203 —
Tracked lines 27020 27114 +94
Branches 10106 10136 +30
==========================================
+ Hits 24404 24469 +65
- Misses 2616 2645 +29
- Partials 1534 1539 +5Generated by Coverage Action |
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
2 times, most recently
from
November 10, 2026 13:55
c77498f to
d920520
Compare
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
from
November 10, 2026 13:56
d920520 to
ce4225d
Compare
alexander-alderman-webb
marked this pull request as ready for review
November 10, 2026 13:58
sentrivana
approved these changes
Nov 10, 2026
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
2 times, most recently
from
November 10, 2026 15:54
78e7752 to
4335059
Compare
alexander-alderman-webb
enabled auto-merge (squash)
November 10, 2026 15:56
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4335059. Configure here.
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
2 times, most recently
from
November 10, 2026 16:03
7eed4f8 to
fbfe80f
Compare
alexander-alderman-webb
force-pushed
the
webb/bedrock/token-attributes
branch
from
November 10, 2026 16:04
fbfe80f to
356182c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change the extension interface to require
on_success_response()instead ofget_response_attributes().This is required so that the Bedrock extension closes the span when the streamed model response is completed or is unexpectedly suspended.
Handle iterators for streaming responses analogously to other GenAI integrations, and add a test with an error bubbling up during stream iteration.
The current pattern is setting the span status to error if anything other than a
GeneratorExitbubbles through the iteration.