Repository navigation
Conversation
If the crash daemon is killed abruptly, or has not attached yet, the crash is lost: the next launch deletes its `__sentry-event` with the old run folder. This is more likely on Android, where the daemon runs in a service process that the system can kill independently of the app, for example under memory pressure, and that may not have connected yet when the app crashes. Recover the event instead. The daemon removes the file once it has sent the crash or kept its own envelope.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e1120e. Configure here.
A daemon killed after writing `__sentry-crash.envelope` but before removing `__sentry-event` left both files, and the next launch invoked `on_crashed_last_run` for each. Send the daemon's envelope instead and remove the event.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v1 #2330 +/- ##
==========================================
- Coverage 75.72% 75.49% -0.23%
==========================================
Files 105 105
Lines 30936 30985 +49
Branches 5775 5784 +9
==========================================
- Hits 23426 23392 -34
- Misses 6075 6180 +105
+ Partials 1435 1413 -22 🚀 New features to boost your workflow:
|
9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Originates from:
If the crash daemon was killed abruptly, or had not attached yet, the crash was lost: the next launch deleted its
__sentry-eventwith the old run folder. This is more likely on Android, where the daemon runs in a service process that the system can kill independently of the app, for example under memory pressure, and that may not have connected yet when the app crashes.Recover the event instead. The daemon removes the file once it has sent the crash or kept its own envelope.