ref(transport): move crash-time disk dumping into transport - #1938
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
+ Coverage 75.79% 75.87% +0.08%
==========================================
Files 93 93
Lines 22167 22156 -11
Branches 3944 3945 +1
==========================================
+ Hits 16801 16811 +10
+ Misses 4483 4464 -19
+ Partials 883 881 -2 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/transport-crash-dump
branch
from
August 3, 2026 09:39
6fd9e4d to
e134668
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/transport-crash-dump
branch
from
August 3, 2026 12:50
e134668 to
6be63d4
Compare
Let crash backends suspend the transport's network submission and automatically route crash-time envelopes through its disk-dump path. This removes the need for allocating fallback disk transports in the backends, and prepares for the upcoming thread-pool telemetry module, which cannot safely drain the transport queue from a crash handler.
jpnurmi
force-pushed
the
jpnurmi/ref/transport-crash-dump
branch
from
August 3, 2026 12:53
6be63d4 to
6883ac0
Compare
jpnurmi
marked this pull request as ready for review
August 3, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let crash backends suspend the transport's network submission and automatically route crash-time envelopes through its disk-dump path.
This removes the need for allocating fallback disk transports in the backends, and more importantly, prepares for the upcoming thread-pool telemetry module, which cannot safely drain the transport queue from a crash handler (see #1883 (comment) and #1883 (comment) for more details). This change abstracts away the problem so that callers no longer need to care whether the SDK has already started dumping in-flight envelopes to disk.
Before (pseudo)
After (pseudo)
#skip-changelog (internal refactor)