Repository navigation
test(node): Port basic and nested startSpan tests to streaming - #25214
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 9, 2026 11:36
nicohrubec
requested review from
JPeer264,
Lms24,
isaacs and
mydea
and removed request for
a team
October 9, 2026 11:36
Lms24
approved these changes
Oct 12, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
l: I'd prefer keeping static and streamed versions of these test around.
approving to unblock.
Member
Author
|
@Lms24 sure, will add a static copy before merging. thanks! |
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
JPeer264
approved these changes
Oct 12, 2026
Contributor
size-limit report 📦
|
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise basic and nested span creation with the default streaming lifecycle. Keep static counterparts for every suite, including basic usage with children, to preserve transaction coverage.
Part of #24140