fix: Injection silently no-ops on Windows (registerHooks path) - #24705
Merged
Merged
Conversation
timfish
requested review from
isaacs,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 24, 2026 16:07
@apm-js-collab/tracing-hooks to 0.13.3
@apm-js-collab/tracing-hooks to 0.13.3registerHooks path)
Contributor
size-limit report 📦
|
isaacs
approved these changes
Sep 24, 2026
Member
|
E2e failures are unrelated. Attempting to de-flake in #24708 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerHookspath) #24695Bumps
@apm-js-collab/tracing-hooksto 0.13.3 in@sentry/server-runtime-injectionto pick up the Windows fix for orchestrion diagnostics-channel injection (apm-js-collab/tracing-hooks#58). Without it, syncModule.registerHooks()instrumentation silently no-ops on Windows and Node 24.13+.