Skip to content

fix: Injection silently no-ops on Windows (registerHooks path) - #24705

Merged
isaacs merged 1 commit into
developfrom
deps/tracing-hooks-0.13.3
Sep 24, 2026
Merged

isaacs merged 1 commit into
developfrom
deps/tracing-hooks-0.13.3

Conversation

@timfish

@timfish timfish commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Bumps @apm-js-collab/tracing-hooks to 0.13.3 in @sentry/server-runtime-injection to pick up the Windows fix for orchestrion diagnostics-channel injection (apm-js-collab/tracing-hooks#58). Without it, sync Module.registerHooks() instrumentation silently no-ops on Windows and Node 24.13+.

@timfish
timfish requested a review from a team as a code owner September 24, 2026 16:07
@timfish
timfish requested review from isaacs, logaretm and stephanie-anderson and removed request for a team and stephanie-anderson September 24, 2026 16:07
@timfish timfish changed the title deps: Bump @apm-js-collab/tracing-hooks to 0.13.3 deps: Bump @apm-js-collab/tracing-hooks to 0.13.3 Sep 24, 2026
@timfish timfish changed the title deps: Bump @apm-js-collab/tracing-hooks to 0.13.3 fix: Injection silently no-ops on Windows (registerHooks path) Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.24 kB - -
@sentry/browser - with treeshaking flags 27.5 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.4 kB - -
@sentry/browser (incl. Tracing) 51.15 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.17 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.18 kB - -
@sentry/browser (incl. Tracing, Replay) 90.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.46 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.41 kB - -
@sentry/browser (incl. Feedback) 46.76 kB - -
@sentry/browser (incl. sendFeedback) 34.3 kB - -
@sentry/browser (incl. FeedbackAsync) 39.41 kB - -
@sentry/browser (incl. Metrics) 30.25 kB - -
@sentry/browser (incl. Logs) 30.51 kB - -
@sentry/browser (incl. Metrics & Logs) 31.18 kB - -
@sentry/react 31 kB - -
@sentry/react (incl. Tracing) 53.45 kB - -
@sentry/vue 36.74 kB - -
@sentry/vue (incl. Tracing) 53.7 kB - -
@sentry/svelte 29.26 kB - -
CDN Bundle 30.93 kB - -
CDN Bundle (incl. Tracing) 51.69 kB - -
CDN Bundle (incl. Logs, Metrics) 33.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.66 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.92 kB - -
CDN Bundle (incl. Tracing, Replay) 89.28 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.45 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.42 kB - -
CDN Bundle - uncompressed 91.4 kB - -
CDN Bundle (incl. Tracing) - uncompressed 153.77 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.97 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 159.73 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.54 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 273.5 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 279.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.13 kB - -
@sentry/nextjs (client) 55.77 kB - -
@sentry/sveltekit (client) 51.59 kB - -
@sentry/core/server 39.95 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 133.9 kB +0.03% +30 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.43 kB +0.04% +26 B 🔺
@sentry/node - without tracing 90.46 kB +0.05% +41 B 🔺
@sentry/node - without channel injection 112.42 kB +0.01% +11 B 🔺
@sentry/aws-serverless 98.72 kB +0.03% +28 B 🔺
@sentry/cloudflare (withSentry) - minified 206.49 kB - -
@sentry/cloudflare (withSentry) 513.73 kB - -

View base workflow run

@isaacs

isaacs commented Sep 24, 2026

Copy link
Copy Markdown
Member

E2e failures are unrelated. Attempting to de-flake in #24708

@isaacs
isaacs enabled auto-merge (squash) September 24, 2026 18:25
@isaacs
isaacs merged commit d5a1b35 into develop Sep 24, 2026
638 of 642 checks passed
@isaacs
isaacs deleted the deps/tracing-hooks-0.13.3 branch September 24, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Injection silently no-ops on Windows (registerHooks path)

2 participants