fix(node): Register diagnostics-channel injection in NodeClient con… - #24293
Merged
Conversation
timfish
requested review from
logaretm and
stephanie-anderson
and removed request for
a team
September 10, 2026 11:22
mydea
approved these changes
Sep 10, 2026
Contributor
size-limit report 📦
|
Collaborator
Author
|
Not sure I believe the size limit report 🤔 |
timfish
requested review from
JPeer264
and removed request for
stephanie-anderson
September 10, 2026 11:39
Collaborator
Author
|
Blocked on #24303 |
timfish
enabled auto-merge (squash)
September 10, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
registerDiagnosticsChannelInjection()from the Node SDK'sinit()into theNodeClientconstructor, so the injection hooks install for every client, not only the one built byinit(). Downstream SDKs that construct a client without going throughinit()now get channel injection set up for them.The call keeps its existing guards (the
__SENTRY_CHANNEL_INJECTION__build flag andenableRuntimeChannelInjection: false), read from the constructor'soptions. Registration is idempotent, so construction on any path stays safe. This follows the same constructor-anchoring pattern already used for_INTERNAL_setDeferSegmentSpanCaptureandregisterPrepareSpanScope.