Skip to content

test(node): Port express maxIncomingRequestBodySize suite to span streaming #24193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chargome wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

test(node): Port express maxIncomingRequestBodySize suite to span streaming #24193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...tegration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-always.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
1 change: 0 additions & 1 deletion ...egration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-default.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
1 change: 0 additions & 1 deletion ...tegration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-medium.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
1 change: 0 additions & 1 deletion ...integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-none.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
1 change: 0 additions & 1 deletion ...ntegration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-small.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
149 changes: 83 additions & 66 deletions ...ckages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ describe('express with httpIntegration and not defined maxRequestBodySize', () =
test('captures medium request bodies with default setting (medium)', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: JSON.stringify(generatePayload(MAX_MEDIUM)),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: JSON.stringify(generatePayload(MAX_MEDIUM)) },
}),
});
},
})
.start();
Expand All @@ -41,11 +43,13 @@ describe('express with httpIntegration and not defined maxRequestBodySize', () =
test('truncates large request bodies with default setting (medium)', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: generatePayloadString(MAX_MEDIUM, true),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: generatePayloadString(MAX_MEDIUM, true) },
}),
});
},
})
.start();
Expand All @@ -69,11 +73,13 @@ describe('express with httpIntegration, disabled httpBodies, and explicit maxReq
test('captures request bodies because the explicit size overrides dataCollection.httpBodies', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: JSON.stringify(generatePayload(MAX_SMALL)),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: JSON.stringify(generatePayload(MAX_SMALL)) },
}),
});
},
})
.start();
Expand All @@ -97,11 +103,10 @@ describe('express with httpIntegration and maxRequestBodySize: "none"', () => {
test('does not capture any request bodies with "none" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: expect.not.objectContaining({
data: expect.any(String),
}),
span: container => {
const serverSpan = container.items.find(item => item.is_segment);
expect(serverSpan?.name).toBe('POST /test-body-size');
expect(serverSpan?.attributes['http.request.body.data']).toBeUndefined();
},
})
.start();
Expand All @@ -117,19 +122,17 @@ describe('express with httpIntegration and maxRequestBodySize: "none"', () => {
test('does not capture any request bodies with "none" setting and "ignoreRequestBody"', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: expect.not.objectContaining({
data: expect.any(String),
}),
span: container => {
const serverSpan = container.items.find(item => item.is_segment);
expect(serverSpan?.name).toBe('POST /test-body-size');
expect(serverSpan?.attributes['http.request.body.data']).toBeUndefined();
},
})
.expect({
transaction: {
transaction: 'POST /ignore-request-body',
request: expect.not.objectContaining({
data: expect.any(String),
}),
span: container => {
const serverSpan = container.items.find(item => item.is_segment);
expect(serverSpan?.name).toBe('POST /ignore-request-body');
expect(serverSpan?.attributes['http.request.body.data']).toBeUndefined();
},
})
.start();
Expand Down Expand Up @@ -158,11 +161,13 @@ describe('express with httpIntegration and maxRequestBodySize: "always"', () =>
test('captures maximum allowed request body length with "always" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: JSON.stringify(generatePayload(MAX_GENERAL)),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: JSON.stringify(generatePayload(MAX_GENERAL)) },
}),
});
},
})
.start();
Expand All @@ -178,11 +183,13 @@ describe('express with httpIntegration and maxRequestBodySize: "always"', () =>
test('captures large request bodies with "always" setting but respects maximum size limit', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: generatePayloadString(MAX_GENERAL, true),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: generatePayloadString(MAX_GENERAL, true) },
}),
});
},
})
.start();
Expand All @@ -206,11 +213,13 @@ describe('express with httpIntegration and maxRequestBodySize: "small"', () => {
test('keeps small request bodies with "small" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: JSON.stringify(generatePayload(MAX_SMALL)),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: JSON.stringify(generatePayload(MAX_SMALL)) },
}),
});
},
})
.start();
Expand All @@ -226,11 +235,13 @@ describe('express with httpIntegration and maxRequestBodySize: "small"', () => {
test('truncates too large request bodies with "small" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: generatePayloadString(MAX_SMALL, true),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: generatePayloadString(MAX_SMALL, true) },
}),
});
},
})
.start();
Expand All @@ -246,12 +257,14 @@ describe('express with httpIntegration and maxRequestBodySize: "small"', () => {
test('truncates too large non-ASCII request bodies with "small" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
// 250 emojis, each 4 bytes in UTF-8 (resulting in 1000 bytes --> MAX_SMALL)
data: generateEmojiPayloadString(250, true),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
// 250 emojis, each 4 bytes in UTF-8 (resulting in 1000 bytes --> MAX_SMALL)
'http.request.body.data': { type: 'string', value: generateEmojiPayloadString(250, true) },
}),
});
},
})
.start();
Expand All @@ -275,11 +288,13 @@ describe('express with httpIntegration and maxRequestBodySize: "medium"', () =>
test('keeps medium request bodies with "medium" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: JSON.stringify(generatePayload(MAX_MEDIUM)),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: JSON.stringify(generatePayload(MAX_MEDIUM)) },
}),
});
},
})
.start();
Expand All @@ -295,11 +310,13 @@ describe('express with httpIntegration and maxRequestBodySize: "medium"', () =>
test('truncates large request bodies with "medium" setting', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'POST /test-body-size',
request: {
data: generatePayloadString(MAX_MEDIUM, true),
},
span: container => {
expect(container.items.find(item => item.is_segment)).toMatchObject({
name: 'POST /test-body-size',
attributes: expect.objectContaining({
'http.request.body.data': { type: 'string', value: generatePayloadString(MAX_MEDIUM, true) },
}),
});
},
})
.start();
Expand Down
Loading