test(e2e): Port the TanStack Start React E2E app to span streaming - #24172
Merged
Conversation
Contributor
size-limit report 📦
|
RulaKhaled
marked this pull request as ready for review
September 8, 2026 12:15
s1gr1d
approved these changes
Sep 10, 2026
| const mysqlSpans = spans.filter(span => span.attributes['sentry.origin']?.value === 'auto.db.mysql'); | ||
|
|
||
| const spans = transactionEvent.spans || []; | ||
| const firstQuery = mysqlSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution'); |
Member
There was a problem hiding this comment.
Hm, this should now show 1 + 1, maybe you have to update you branch.
Related to this PR: #24089
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
rolaabuhasna/js-3489/tanstackstart-react
branch
from
September 11, 2026 06:23
9979f3f to
ec9bc7c
Compare
RulaKhaled
enabled auto-merge (squash)
September 11, 2026 06:24
…st leak Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
rolaabuhasna/js-3489/tanstackstart-react
branch
from
September 11, 2026 06:25
ec9bc7c to
45813b7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 45813b7. Configure here.
| expect(clientTx.contexts?.trace?.trace_id).toBe(serverTx.contexts?.trace?.trace_id); | ||
| expect(serverSpan).toBeDefined(); | ||
| expect(clientSpan).toBeDefined(); | ||
| expect(clientSpan?.trace_id).toBe(serverSpan?.trace_id); |
There was a problem hiding this comment.
Trace connection test can false-pass
Medium Severity
collectStreamedSpans already groups by trace_id, so the later trace_id comparison cannot fail. The wait also is not unique to this navigation: the previous test hits / without draining spans, and a leftover connected trace can satisfy the predicate and hide a broken propagation on this page load. Flagged because the review rules call out hollow assertions and waits that are not unique enough for the same route.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 45813b7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes span streaming the only path in the TanStack Start React E2E app. The
E2E_TEST_STREAMED_SPANSternary is gone, and the specs wait on streamed spans instead of transaction envelopes.Why
Unparameterized
http.servernames fall back to the method only, so those waits matchurl.path(andhttp.routeonce a route is known). Redis handshake commands and mysql query-summary names (SELECT) are told apart withdb.query.text. Thetunnel-streamedvariant is dropped because it is now identical totunnel-generated. Static-lifecycle coverage moves totanstackstart-react-static.Part of #23805