test(e2e): Port the TanStack Router E2E app to span streaming - #24171
Open
RulaKhaled wants to merge 2 commits into
Open
test(e2e): Port the TanStack Router E2E app to span streaming#24171RulaKhaled wants to merge 2 commits into
RulaKhaled wants to merge 2 commits into
Conversation
Loader spans arrive in a different envelope than the pageload or navigation segment, so those specs accumulate with collectStreamedSpans. Web vitals are not on streamed pageload spans. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
RulaKhaled
marked this pull request as ready for review
September 8, 2026 12:15
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8891239. Configure here.
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin from the TanStack Router E2E app and rewrites the routing and basepath specs onto streamed spans.Why
Loader spans arrive across envelopes, so those tests collect with
collectStreamedSpansinstead of readingtransactionEvent.spans. Route names stay/posts/$postId; the React SDK usesurl.path.params.postId.Part of #23805